From bf5ba9b24fbc3d98dc7e1475c8a77efeb4c90ecf Mon Sep 17 00:00:00 2001 From: Go MAEDA Date: Fri, 20 Sep 2024 10:24:53 +0000 Subject: [PATCH] Moves thumbnail title attribute from `a` to `img` (#41272). MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Patch by Jens Krämer (user:jkraemer). git-svn-id: https://svn.redmine.org/redmine/trunk@23065 e93f8b46-1217-0410-a6f0-8f06a7374b81 --- app/helpers/application_helper.rb | 4 ++-- test/helpers/application_helper_test.rb | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb index 7e13c995c..b11619088 100644 --- a/app/helpers/application_helper.rb +++ b/app/helpers/application_helper.rb @@ -351,12 +351,12 @@ module ApplicationHelper thumbnail_path, :srcset => "#{thumbnail_path} 2x", :style => "max-width: #{thumbnail_size}px; max-height: #{thumbnail_size}px;", + :title => attachment.filename, :loading => "lazy" ), attachment_path( attachment - ), - :title => attachment.filename + ) ) end diff --git a/test/helpers/application_helper_test.rb b/test/helpers/application_helper_test.rb index 76b39545c..bad102c20 100644 --- a/test/helpers/application_helper_test.rb +++ b/test/helpers/application_helper_test.rb @@ -1932,7 +1932,7 @@ class ApplicationHelperTest < Redmine::HelperTest a = Attachment.find(3) assert_select_in( thumbnail_tag(a), - 'a[href=?][title=?] img[src=?][loading="lazy"]', + 'a[href=?] img[title=?][src=?][loading="lazy"]', "/attachments/3", "logo.gif", "/attachments/thumbnail/3/200") end -- 2.39.5