From c40e1507900e00b37c7dd07407b7fa32f557a9a7 Mon Sep 17 00:00:00 2001 From: David Pursehouse Date: Wed, 6 Dec 2017 23:31:38 +0900 Subject: [PATCH] InMemoryRepository: Make inner class MemObjDatabase static FindBugs reports: This class is an inner class, but does not use its embedded reference to the object which created it. This reference makes the instances of the class larger, and may keep the reference to the creator object alive longer than necessary. If possible, the class should be made static. Change-Id: I9f49de32b4cd81b7ef1239b390353689263bf66e Signed-off-by: David Pursehouse --- .../eclipse/jgit/internal/storage/dfs/InMemoryRepository.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/dfs/InMemoryRepository.java b/org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/dfs/InMemoryRepository.java index 383ed3d016..1e31878b39 100644 --- a/org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/dfs/InMemoryRepository.java +++ b/org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/dfs/InMemoryRepository.java @@ -107,7 +107,7 @@ public class InMemoryRepository extends DfsRepository { } /** DfsObjDatabase used by InMemoryRepository. */ - public class MemObjDatabase extends DfsObjDatabase { + public static class MemObjDatabase extends DfsObjDatabase { private List packs = new ArrayList<>(); private int blockSize; -- 2.39.5