From c4bd14f1bb66f48eccbd4c491ae76873729ab899 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Scott=20Gonz=C3=A1lez?= Date: Sat, 6 Aug 2011 12:49:11 -0400 Subject: [PATCH] Spinner: Don't stop propagation for keydown events. --- ui/jquery.ui.spinner.js | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/ui/jquery.ui.spinner.js b/ui/jquery.ui.spinner.js index 20c8d5e3d..47fb3e6f7 100644 --- a/ui/jquery.ui.spinner.js +++ b/ui/jquery.ui.spinner.js @@ -66,9 +66,8 @@ $.widget( "ui.spinner", { this.element.attr( "role", "spinbutton" ); this._bind({ keydown: function( event ) { - if ( this._start( event ) ) { - // TODO: don't stop propagation - return this._keydown( event ); + if ( this._start( event ) && this._keydown( event ) ) { + event.preventDefault(); } }, keyup: function( event ) { @@ -144,21 +143,21 @@ $.widget( "ui.spinner", { switch ( event.keyCode ) { case keyCode.UP: this._repeat( null, 1, event ); - return false; + return true; case keyCode.DOWN: this._repeat( null, -1, event ); - return false; + return true; case keyCode.PAGE_UP: this._repeat( null, options.page, event ); - return false; + return true; case keyCode.PAGE_DOWN: this._repeat( null, -options.page, event ); - return false; + return true; case keyCode.ENTER: this.value( this.element.val() ); } - return true; + return false; }, _mousewheel: function() { -- 2.39.5