From c5fcebb65dfae620bcff64d9104cce4262e2d352 Mon Sep 17 00:00:00 2001 From: Joas Schilling Date: Thu, 27 Oct 2022 07:10:57 +0200 Subject: [PATCH] Continue registering and loading other dashboard widgets when one failed creation Signed-off-by: Joas Schilling --- lib/private/Dashboard/Manager.php | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/lib/private/Dashboard/Manager.php b/lib/private/Dashboard/Manager.php index 2aeedf3174e..a2dcf42941b 100644 --- a/lib/private/Dashboard/Manager.php +++ b/lib/private/Dashboard/Manager.php @@ -82,9 +82,10 @@ class Manager implements IManager { * we can not inject it. Thus the static call. */ \OC::$server->get(LoggerInterface::class)->critical( - 'Could not load lazy dashboard widget: ' . $e->getMessage(), - ['excepiton' => $e] + 'Could not load lazy dashboard widget: ' . $service['class'], + ['exception' => $e] ); + continue; } /** * Try to register the loaded reporter. Theoretically it could be of a wrong @@ -98,9 +99,10 @@ class Manager implements IManager { * we can not inject it. Thus the static call. */ \OC::$server->get(LoggerInterface::class)->critical( - 'Could not register lazy dashboard widget: ' . $e->getMessage(), + 'Could not register lazy dashboard widget: ' . $service['class'], ['exception' => $e] ); + continue; } try { @@ -119,9 +121,10 @@ class Manager implements IManager { } } catch (Throwable $e) { \OC::$server->get(LoggerInterface::class)->critical( - 'Error during dashboard widget loading: ' . $e->getMessage(), + 'Error during dashboard widget loading: ' . $service['class'], ['exception' => $e] ); + continue; } } $this->lazyWidgets = []; -- 2.39.5