From c6b97a85498d59744db1da0786b446231efbc7d3 Mon Sep 17 00:00:00 2001 From: Matti Tahvonen Date: Tue, 11 Jan 2011 11:15:26 +0000 Subject: [PATCH] fixed two bugs that prevents paintables to be cleaned. Commented out some obsolete debug code. svn changeset:16850/svn branch:6.5 --- .../gwt/client/ApplicationConnection.java | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/src/com/vaadin/terminal/gwt/client/ApplicationConnection.java b/src/com/vaadin/terminal/gwt/client/ApplicationConnection.java index f52c429724..624f3beee7 100755 --- a/src/com/vaadin/terminal/gwt/client/ApplicationConnection.java +++ b/src/com/vaadin/terminal/gwt/client/ApplicationConnection.java @@ -977,7 +977,7 @@ public class ApplicationConnection { } } - if (!repaintAll) { + if (repaintAll) { /* * idToPaintableDetail is already cleanded at the start of * the changeset handling, bypass cleanup. @@ -1103,7 +1103,18 @@ public class ApplicationConnection { } String id = getPid(p); if (id == null) { - VConsole.log("Trying to unregister Paintable not created by Application Connection."); + /* + * Uncomment the following to debug unregistring components. No + * paintables with null id should end here. At least one exception + * is our VScrollTableRow, that is hacked to fake it self as a + * Paintable to build support for sizing easier. + */ + // if (!(p instanceof VScrollTableRow)) { + // VConsole.log("Trying to unregister Paintable not created by Application Connection."); + // } + if (p instanceof HasWidgets) { + unregisterChildPaintables((HasWidgets) p); + } } else { unregistryBag.add(id); if (p instanceof HasWidgets) { -- 2.39.5