From ca53eef3174fb49156572c138a011475d05ce4c0 Mon Sep 17 00:00:00 2001 From: Louis Chemineau Date: Wed, 22 Mar 2023 13:54:29 +0100 Subject: [PATCH] Increase wait to ensure versions are created In files_versions cypress tests, we wait for 1000ms between each versions uploads to make sure that the server properly create a version. Under 1s the serve does not create a version. This commit increases the wait time as it might help to ensure that the time span is enough between two uploads. Signed-off-by: Louis Chemineau --- .../e2e/files_versions/filesVersionsUtils.ts | 4 +- cypress/support/commands.ts | 51 +++++++++---------- 2 files changed, 27 insertions(+), 28 deletions(-) diff --git a/cypress/e2e/files_versions/filesVersionsUtils.ts b/cypress/e2e/files_versions/filesVersionsUtils.ts index 1aa7ebde316..e2267538471 100644 --- a/cypress/e2e/files_versions/filesVersionsUtils.ts +++ b/cypress/e2e/files_versions/filesVersionsUtils.ts @@ -24,9 +24,9 @@ import path from "path" export function uploadThreeVersions(user) { cy.uploadContent(user, new Blob(['v1'], { type: 'text/plain' }), 'text/plain', '/test.txt') - cy.wait(1000) + cy.wait(1500) cy.uploadContent(user, new Blob(['v2'], { type: 'text/plain' }), 'text/plain', '/test.txt') - cy.wait(1000) + cy.wait(1500) cy.uploadContent(user, new Blob(['v3'], { type: 'text/plain' }), 'text/plain', '/test.txt') cy.login(user) } diff --git a/cypress/support/commands.ts b/cypress/support/commands.ts index d214bb2b45e..1a9999343d5 100644 --- a/cypress/support/commands.ts +++ b/cypress/support/commands.ts @@ -99,33 +99,32 @@ Cypress.Commands.add('uploadFile', (user, fixture = 'image.jpg', mimeType = 'ima */ Cypress.Commands.add('uploadContent', (user, blob, mimeType, target) => { cy.clearCookies() - .then(async () => { - const fileName = basename(target) - - // Process paths - const rootPath = `${Cypress.env('baseUrl')}/remote.php/dav/files/${encodeURIComponent(user.userId)}` - const filePath = target.split('/').map(encodeURIComponent).join('/') - try { - const file = new File([blob], fileName, { type: mimeType }) - await axios({ - url: `${rootPath}${filePath}`, - method: 'PUT', - data: file, - headers: { - 'Content-Type': mimeType, - }, - auth: { - username: user.userId, - password: user.password, - }, - }).then(response => { + .then(async () => { + const fileName = basename(target) + + // Process paths + const rootPath = `${Cypress.env('baseUrl')}/remote.php/dav/files/${encodeURIComponent(user.userId)}` + const filePath = target.split('/').map(encodeURIComponent).join('/') + try { + const file = new File([blob], fileName, { type: mimeType }) + const response = await axios({ + url: `${rootPath}${filePath}`, + method: 'PUT', + data: file, + headers: { + 'Content-Type': mimeType, + }, + auth: { + username: user.userId, + password: user.password, + }, + }) cy.log(`Uploaded content as ${fileName}`, response) - }) - } catch (error) { - cy.log('error', error) - throw new Error(`Unable to process fixture`) - } - }) + } catch (error) { + cy.log('error', error) + throw new Error('Unable to process fixture') + } + }) }) /** -- 2.39.5