From ccc0e45d030eef468e8ff16c5f2727452d941235 Mon Sep 17 00:00:00 2001
From: Stephane Gamard <stephane.gamard@sonarsource.com>
Date: Tue, 9 Sep 2014 15:57:50 +0200
Subject: [PATCH] SONAR-5530 - Using *Finders for context objects in
 IssueResult

---
 .../java/org/sonar/server/issue/IssueService.java    |  6 +++---
 .../org/sonar/server/issue/index/IssueResult.java    | 12 ++++++++----
 2 files changed, 11 insertions(+), 7 deletions(-)

diff --git a/server/sonar-server/src/main/java/org/sonar/server/issue/IssueService.java b/server/sonar-server/src/main/java/org/sonar/server/issue/IssueService.java
index d94a90de508..4c9172902e3 100644
--- a/server/sonar-server/src/main/java/org/sonar/server/issue/IssueService.java
+++ b/server/sonar-server/src/main/java/org/sonar/server/issue/IssueService.java
@@ -354,7 +354,6 @@ public class IssueService implements ServerComponent {
       (options.getOffset() * options.getLimit()) + 1,
       new Long(esResults.getHits().getTotalHits()).intValue()));
 
-
     // Insert the projects and component name;
     Set<RuleKey> ruleKeys = new HashSet<RuleKey>();
     Set<String> projectKeys = new HashSet<String>();
@@ -372,11 +371,12 @@ public class IssueService implements ServerComponent {
     }
 
     try {
+      // TODO Rule vs Rule problem
       indexClient.get(RuleIndex.class).getByKeys(ruleKeys);
       result.addProjects(dbClient.componentDao().getByKeys(session, projectKeys));
       result.addComponents(dbClient.componentDao().getByKeys(session, componentKeys));
-   dbClient.userDao().selectUsersByLogins(session, userLogins);
-      dbClient.actionPlanDao().findByKeys(actionPlanKeys);
+      result.addUsers(userFinder.findByLogins(userLogins));
+      result.addActionPlans(actionPlanService.findByKeys(actionPlanKeys));
     } finally {
       session.close();
     }
diff --git a/server/sonar-server/src/main/java/org/sonar/server/issue/index/IssueResult.java b/server/sonar-server/src/main/java/org/sonar/server/issue/index/IssueResult.java
index 052743306f3..66a7efe38a8 100644
--- a/server/sonar-server/src/main/java/org/sonar/server/issue/index/IssueResult.java
+++ b/server/sonar-server/src/main/java/org/sonar/server/issue/index/IssueResult.java
@@ -148,12 +148,16 @@ public class IssueResult extends Result<IssueDoc> implements IssueQueryResult {
  }
   }
 
-  public void addUsers(User user) {
-    this.usersByLogin.put(user.login(), user);
+  public void addUsers(Collection<User> users) {
+    for (User user : users) {
+      this.usersByLogin.put(user.login(), user);
+    }
   }
 
-  public void addActionPlans(ActionPlan plan) {
-    this.actionPlans.put(plan.key(), plan);
+  public void addActionPlans(Collection<ActionPlan> plans) {
+    for (ActionPlan plan : plans) {
+      this.actionPlans.put(plan.key(), plan);
+    }
   }
 
   public void addRules(Rule rule) {
-- 
2.39.5