From cecb52ff5c5c5c6a030b6520dc1e39ec4c6df3d9 Mon Sep 17 00:00:00 2001 From: Timmy Willison Date: Thu, 15 Aug 2013 20:38:48 -0400 Subject: [PATCH] Specify support as a dependency wherever it is used. Optimize module order to save 15 bytes. --- README.md | 2 +- src/ajax/xhr.js | 3 ++- src/attributes/attr.js | 3 ++- src/attributes/prop.js | 3 ++- src/attributes/val.js | 3 ++- src/css.js | 4 +++- src/jquery.js | 4 ++-- src/manipulation.js | 3 ++- src/offset.js | 4 ++-- src/support.js | 4 +++- 10 files changed, 21 insertions(+), 12 deletions(-) diff --git a/README.md b/README.md index 382853366..93790c913 100644 --- a/README.md +++ b/README.md @@ -86,7 +86,7 @@ Some example modules that can be excluded are: - **offset**: The `.offset()`, `.position()`, `.offsetParent()`, `.scrollLeft()`, and `.scrollTop()` methods. - **wrap**: The `.wrap()`, `.wrapAll()`, `.wrapInner()`, and `.unwrap()` methods. - **exports/amd**: Exclude the AMD definition. -- **core/ready**: Exclude the ready module if you place your scripts at the end of the body. Any ready callbacks will simply be called immediately. +- **core/ready**: Exclude the ready module if you place your scripts at the end of the body. Any ready callbacks bound with `jQuery()` will simply be called immediately. However, `jQuery(document).ready()` will not be a function and `.on("ready", ...)` or similar will not be triggered. - **deferred**: Exclude jQuery.Deferred. This also removes jQuery.Callbacks. *Note* that modules that depend on jQuery.Deferred(AJAX, effects, core/ready) will not be removed and will still expect jQuery.Deferred to be there. Include your own jQuery.Deferred implementation or exclude those modules as well (`grunt custom:-deferred,-ajax,-effects,-core/ready`). - **support**: Excluding the support module is not recommended, but possible. It's your responsibility to either remove modules that use jQuery.support (many of them) or replace the values wherever jQuery.support is used. This is mainly only useful when building a barebones version of jQuery. diff --git a/src/ajax/xhr.js b/src/ajax/xhr.js index 6feb94d57..fdc5b08d3 100644 --- a/src/ajax/xhr.js +++ b/src/ajax/xhr.js @@ -1,6 +1,7 @@ define([ "../core", - "../ajax" + "../ajax", + "../support" ], function( jQuery ) { jQuery.ajaxSettings.xhr = function() { diff --git a/src/attributes/attr.js b/src/attributes/attr.js index 4e0102bfa..202c7028b 100644 --- a/src/attributes/attr.js +++ b/src/attributes/attr.js @@ -2,7 +2,8 @@ define([ "../core", "../var/rnotwhite", "../var/strundefined", - "../selector" + "../selector", + "../support" ], function( jQuery, rnotwhite, strundefined ) { var nodeHook, boolHook; diff --git a/src/attributes/prop.js b/src/attributes/prop.js index f7ce11f97..95462bbbb 100644 --- a/src/attributes/prop.js +++ b/src/attributes/prop.js @@ -1,5 +1,6 @@ define([ - "../core" + "../core", + "../support" ], function( jQuery ) { var rfocusable = /^(?:input|select|textarea|button)$/i; diff --git a/src/attributes/val.js b/src/attributes/val.js index fd8badeb2..73a3bf3ea 100644 --- a/src/attributes/val.js +++ b/src/attributes/val.js @@ -1,5 +1,6 @@ define([ - "../core" + "../core", + "../support" ], function( jQuery ) { var rreturn = /\r/g; diff --git a/src/css.js b/src/css.js index f35700247..16c093bd7 100644 --- a/src/css.js +++ b/src/css.js @@ -6,7 +6,9 @@ define([ "./css/defaultDisplay", "./data/var/data_priv", "./core/swap", - "./selector" // contains + "./core/ready", + "./selector", // contains + "./support" ], function( jQuery, pnum, cssExpand, isHidden, defaultDisplay, data_priv ) { var curCSS, // swappable if display is none or starts with table except "table", "table-cell", or "table-caption" diff --git a/src/jquery.js b/src/jquery.js index ce3ad8e2f..644f29255 100644 --- a/src/jquery.js +++ b/src/jquery.js @@ -1,10 +1,11 @@ define([ "./core", "./selector", + "./traversing", "./callbacks", "./deferred", "./core/ready", - "./traversing", + "./support", "./data", "./queue", "./queue/delay", @@ -26,7 +27,6 @@ define([ "./effects/animated-selector", "./offset", "./dimensions", - "./support", "./deprecated" ], function( jQuery ) { diff --git a/src/manipulation.js b/src/manipulation.js index 8eabb1979..89cc46c62 100644 --- a/src/manipulation.js +++ b/src/manipulation.js @@ -8,7 +8,8 @@ define([ "./data/accepts", "./selector", "./traversing", - "./event" + "./event", + "./support" ], function( jQuery, concat, push, rcheckableType, data_priv, data_user ){ var rxhtmlTag = /<(?!area|br|col|embed|hr|img|input|link|meta|param)(([\w:]+)[^>]*)\/>/gi, diff --git a/src/offset.js b/src/offset.js index 60ceb41ff..45a4a7fa8 100644 --- a/src/offset.js +++ b/src/offset.js @@ -2,7 +2,7 @@ define([ "./core", "./var/strundefined", "./css", - "./selector" + "./selector" // contains ], function( jQuery, strundefined ) { var docElem = window.document.documentElement; @@ -136,7 +136,7 @@ jQuery.fn.extend({ return this.map(function() { var offsetParent = this.offsetParent || docElem; - while ( offsetParent && ( !jQuery.nodeName( offsetParent, "html" ) && jQuery.css( offsetParent, "position") === "static" ) ) { + while ( offsetParent && ( !jQuery.nodeName( offsetParent, "html" ) && jQuery.css( offsetParent, "position" ) === "static" ) ) { offsetParent = offsetParent.offsetParent; } diff --git a/src/support.js b/src/support.js index a02e97d2e..5880e2310 100644 --- a/src/support.js +++ b/src/support.js @@ -1,6 +1,8 @@ define([ "./core", - "./core/swap" + "./core/swap", + // This is listed as a dependency for build order, but it's still optional in builds + "./core/ready" ], function( jQuery ) { jQuery.support = (function( support ) { -- 2.39.5