From d035b237f9803f706e5e3184c307cf0211466931 Mon Sep 17 00:00:00 2001 From: Jean-Baptiste Lievremont Date: Wed, 21 May 2014 16:55:58 +0200 Subject: [PATCH] SONAR-5007 SONAR-5137 Link activate/deactivate buttons --- ...ng-rules-detail-quality-profile-view.coffee | 9 ++++++++- ...g-rules-detail-quality-profiles-view.coffee | 3 ++- .../views/coding-rules-detail-view.coffee | 2 ++ ...ules-quality-profile-activation-view.coffee | 18 ++++++++++++------ .../coding-rules-detail-quality-profile.hbs | 4 ++-- 5 files changed, 26 insertions(+), 10 deletions(-) diff --git a/sonar-server/src/main/coffee/coding-rules/views/coding-rules-detail-quality-profile-view.coffee b/sonar-server/src/main/coffee/coding-rules/views/coding-rules-detail-quality-profile-view.coffee index 3974e84236b..a56c7df47d4 100644 --- a/sonar-server/src/main/coffee/coding-rules/views/coding-rules-detail-quality-profile-view.coffee +++ b/sonar-server/src/main/coffee/coding-rules/views/coding-rules-detail-quality-profile-view.coffee @@ -46,7 +46,14 @@ define [ deactivate: -> if confirm t 'are_you_sure' - @model.destroy() + jQuery.ajax + type: 'POST' + url: "#{baseUrl}/api/qualityprofiles/deactivate_rule" + data: + profile_key: @model.get('qProfile') + rule_key: @options.rule.get('key') + .done => + @model.destroy() enableUpdate: -> diff --git a/sonar-server/src/main/coffee/coding-rules/views/coding-rules-detail-quality-profiles-view.coffee b/sonar-server/src/main/coffee/coding-rules/views/coding-rules-detail-quality-profiles-view.coffee index 71b0b311062..1a5a9f69462 100644 --- a/sonar-server/src/main/coffee/coding-rules/views/coding-rules-detail-quality-profiles-view.coffee +++ b/sonar-server/src/main/coffee/coding-rules/views/coding-rules-detail-quality-profiles-view.coffee @@ -11,4 +11,5 @@ define [ itemViewOptions: -> app: @options.app - qualityProfiles: @collection \ No newline at end of file + rule: @options.rule + qualityProfiles: @collection diff --git a/sonar-server/src/main/coffee/coding-rules/views/coding-rules-detail-view.coffee b/sonar-server/src/main/coffee/coding-rules/views/coding-rules-detail-view.coffee index 711a10c5b62..3c830c60b02 100644 --- a/sonar-server/src/main/coffee/coding-rules/views/coding-rules-detail-view.coffee +++ b/sonar-server/src/main/coffee/coding-rules/views/coding-rules-detail-view.coffee @@ -59,6 +59,7 @@ define [ @qualityProfilesView = new CodingRulesDetailQualityProfilesView app: @options.app collection: qualityProfiles + rule: @model qualityProfile = @options.app.getQualityProfile() if qualityProfile @@ -69,6 +70,7 @@ define [ @contextQualityProfileView = new CodingRulesDetailQualityProfileView app: @options.app model: @contextProfile + rule: @model @listenTo @contextProfile, 'destroy', @hideContext @model.set 'lang', @options.app.languages[@model.get 'lang'] diff --git a/sonar-server/src/main/coffee/coding-rules/views/coding-rules-quality-profile-activation-view.coffee b/sonar-server/src/main/coffee/coding-rules/views/coding-rules-quality-profile-activation-view.coffee index 3d92ffe0ac0..00180916d33 100644 --- a/sonar-server/src/main/coffee/coding-rules/views/coding-rules-quality-profile-activation-view.coffee +++ b/sonar-server/src/main/coffee/coding-rules/views/coding-rules-quality-profile-activation-view.coffee @@ -24,23 +24,29 @@ define [ activate: -> + profileKey = @ui.qualityProfileSelect.val() + if @model + profileKey = @model.get('qProfile') + severity = @ui.qualityProfileSeverity.val() + @$('.modal-foot').html '' jQuery.ajax type: 'POST' - url: "#{baseUrl}/api/rules/activate" - data: id: 1 + url: "#{baseUrl}/api/qualityprofiles/activate_rule" + data: + profile_key: profileKey + rule_key: @rule.get('key') + severity: severity .done => - severity = @ui.qualityProfileSeverity.val() parameters = @ui.qualityProfileParameters.map(-> key: jQuery(@).prop('name'), value: jQuery(@).val() || jQuery(@).prop('placeholder')).get() if @model @model.set severity: severity, parameters: parameters else - key = @ui.qualityProfileSelect.val() model = new Backbone.Model - name: _.findWhere(@options.app.qualityProfiles, key: key).name - key: key + name: _.findWhere(@options.app.qualityProfiles, key: profileKey).name + key: profileKey severity: severity parameters: parameters @options.app.detailView.qualityProfilesView.collection.add model diff --git a/sonar-server/src/main/hbs/coding-rules/coding-rules-detail-quality-profile.hbs b/sonar-server/src/main/hbs/coding-rules/coding-rules-detail-quality-profile.hbs index 3f174cfce27..61ef4429c51 100644 --- a/sonar-server/src/main/hbs/coding-rules/coding-rules-detail-quality-profile.hbs +++ b/sonar-server/src/main/hbs/coding-rules/coding-rules-detail-quality-profile.hbs @@ -36,7 +36,7 @@
- + {{#if parent}}