From d102cb4ffacc8583c5b51297555c60e711e305bf Mon Sep 17 00:00:00 2001 From: Robin Appelman Date: Thu, 18 Sep 2014 14:23:38 +0200 Subject: [PATCH] Don't test for htaccess if we cant write into the datadir anyway --- core/setup/controller.php | 22 ++++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/core/setup/controller.php b/core/setup/controller.php index c046bd5eaa6..fca16ea27be 100644 --- a/core/setup/controller.php +++ b/core/setup/controller.php @@ -116,16 +116,18 @@ class Controller { $errors = array(); - // Protect data directory here, so we can test if the protection is working - \OC_Setup::protectDataDirectory(); - try { - $htaccessWorking = \OC_Util::isHtaccessWorking(); - } catch (\OC\HintException $e) { - $errors[] = array( - 'error' => $e->getMessage(), - 'hint' => $e->getHint() - ); - $htaccessWorking = false; + if (is_dir($datadir) and is_writable($datadir)) { + // Protect data directory here, so we can test if the protection is working + \OC_Setup::protectDataDirectory(); + try { + $htaccessWorking = \OC_Util::isHtaccessWorking(); + } catch (\OC\HintException $e) { + $errors[] = array( + 'error' => $e->getMessage(), + 'hint' => $e->getHint() + ); + $htaccessWorking = false; + } } if (\OC_Util::runningOnMac()) { -- 2.39.5