From d3173873cc4e1ddd685c9e71b462c33d85689190 Mon Sep 17 00:00:00 2001
From: Dominik Stadler <centic@apache.org>
Date: Sat, 31 Dec 2016 09:43:08 +0000
Subject: [PATCH] Fix some Findbugs reports

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776714 13f79535-47bb-0310-9956-ffa450edef68
---
 .../poi/poifs/filesystem/POIFSFileSystem.java | 26 +++++++++----------
 .../apache/poi/hwmf/record/HwmfBitmap16.java  |  3 +--
 2 files changed, 13 insertions(+), 16 deletions(-)

diff --git a/src/java/org/apache/poi/poifs/filesystem/POIFSFileSystem.java b/src/java/org/apache/poi/poifs/filesystem/POIFSFileSystem.java
index cc482536b5..84f345504d 100644
--- a/src/java/org/apache/poi/poifs/filesystem/POIFSFileSystem.java
+++ b/src/java/org/apache/poi/poifs/filesystem/POIFSFileSystem.java
@@ -19,10 +19,7 @@
 
 package org.apache.poi.poifs.filesystem;
 
-import java.io.File;
-import java.io.FileOutputStream;
-import java.io.IOException;
-import java.io.InputStream;
+import java.io.*;
 
 import org.apache.poi.poifs.dev.POIFSViewable;
 import org.apache.poi.util.CloseIgnoringInputStream;
@@ -152,10 +149,16 @@ public class POIFSFileSystem
         // TODO Make this nicer!
         // Create a new empty POIFS in the file
         POIFSFileSystem tmp = new POIFSFileSystem();
-        FileOutputStream fout = new FileOutputStream(file);
-        tmp.writeFilesystem(fout);
-        fout.close();
-        tmp.close();
+        try {
+            OutputStream out = new FileOutputStream(file);
+            try {
+                tmp.writeFilesystem(out);
+            } finally {
+                out.close();
+            }
+        } finally {
+            tmp.close();
+        }
         
         // Open it up again backed by the file
         return new POIFSFileSystem(file, false);
@@ -166,14 +169,9 @@ public class POIFSFileSystem
      *
      * @param args names of the files; arg[ 0 ] is the input file,
      *             arg[ 1 ] is the output file
-     *
-     * @exception IOException
      */
-
-    public static void main(String args[])
-        throws IOException
+    public static void main(String args[]) throws IOException
     {
         OPOIFSFileSystem.main(args);
     }
 }
-
diff --git a/src/scratchpad/src/org/apache/poi/hwmf/record/HwmfBitmap16.java b/src/scratchpad/src/org/apache/poi/hwmf/record/HwmfBitmap16.java
index 3a774af2e4..6212a0d6ab 100644
--- a/src/scratchpad/src/org/apache/poi/hwmf/record/HwmfBitmap16.java
+++ b/src/scratchpad/src/org/apache/poi/hwmf/record/HwmfBitmap16.java
@@ -74,8 +74,7 @@ public class HwmfBitmap16 {
         }
 
         int length = (((width * bitsPixel + 15) >> 4) << 1) * height;
-        @SuppressWarnings("unused")
-        byte buf[] = IOUtils.toByteArray(leis, length);
+        /*byte buf[] =*/ IOUtils.toByteArray(leis, length);
         
         // TODO: this is not implemented ... please provide a sample, if it
         // ever happens to you, to come here ...
-- 
2.39.5