From d530754343162316fcfb52a38fb782114ec3fcca Mon Sep 17 00:00:00 2001
From: Simon Brandhof <simon.brandhof@gmail.com>
Date: Wed, 28 Nov 2012 15:42:40 +0100
Subject: [PATCH] SONAR-3825 ability to change existing filter without saving
 it

---
 .../WEB-INF/app/controllers/measures_controller.rb   |  4 +---
 .../WEB-INF/app/views/measures/search.html.erb       | 12 ++++++++----
 2 files changed, 9 insertions(+), 7 deletions(-)

diff --git a/sonar-server/src/main/webapp/WEB-INF/app/controllers/measures_controller.rb b/sonar-server/src/main/webapp/WEB-INF/app/controllers/measures_controller.rb
index 395b0f1690f..bca19f33bed 100644
--- a/sonar-server/src/main/webapp/WEB-INF/app/controllers/measures_controller.rb
+++ b/sonar-server/src/main/webapp/WEB-INF/app/controllers/measures_controller.rb
@@ -43,9 +43,7 @@ class MeasuresController < ApplicationController
 
     @filter = find_filter(params[:id])
     @filter.load_criteria_from_data
-    @filter.enable_default_display
-    @filter.execute(self, :user => current_user)
-    render :action => 'search'
+    redirect_to @filter.criteria.merge({:action => 'search', :id => params[:id]})
   end
 
   def save_form
diff --git a/sonar-server/src/main/webapp/WEB-INF/app/views/measures/search.html.erb b/sonar-server/src/main/webapp/WEB-INF/app/views/measures/search.html.erb
index 4a6dc80c257..a1f56543664 100644
--- a/sonar-server/src/main/webapp/WEB-INF/app/views/measures/search.html.erb
+++ b/sonar-server/src/main/webapp/WEB-INF/app/views/measures/search.html.erb
@@ -33,7 +33,7 @@
       var url = decodeURI(window.location.href);
       $j.each(params, function (key, value) {
         url = removeUrlAttr(url, key);
-        url += '&'+ key + '=' + value;
+        url += '&' + key + '=' + value;
       });
       window.location = url;
     }
@@ -178,14 +178,18 @@
 
       <%
          edit_mode = (params[:edit]=='true')
-         unless edit_mode %>
+         unless edit_mode
+      %>
         Display as:
         <% MeasureFilterDisplay.keys.each do |display_key| %>
           <%= link_to_if display_key!=@filter.display.key, display_key, params.merge(:action => 'search', :display => display_key, :id => @filter.id) -%>
         <% end %>
         <a id="edit" href="<%= url_for params.merge({:edit => true, :id => @filter.id}) -%>" class="button"><%= message('configure') -%></a>
-        <% if logged_in? && (@filter.user_id==nil || @filter.user_id==current_user.id) %>
-          <a id="save_as" href="<%= url_for params.merge({:action => 'save_form', :id => @filter.id}) -%>" class="button open-modal"><%= message('save') -%></a>
+        <% if logged_in? %>
+          <% if @filter.id==nil || @filter.user_id==current_user.id %>
+            <a id="save" href="<%= url_for params.merge({:action => 'save_form', :id => @filter.id}) -%>" class="button open-modal"><%= message('save') -%></a>
+          <% end %>
+          <a id="copy" href="<%= url_for params.merge({:action => 'copy_form', :id => @filter.id}) -%>" class="button open-modal"><%= message('copy') -%></a>
         <% end %>
       <% end %>
       <%= render :partial => "measures/display_#{@filter.display.class::KEY}", :locals => {:edit_mode => edit_mode} -%>
-- 
2.39.5