From d908112cc1fe908d8f8925706d3398a499386802 Mon Sep 17 00:00:00 2001 From: Julien Lancelot Date: Wed, 2 Oct 2013 09:24:13 +0200 Subject: [PATCH] Fix some quality flaws --- .../sonar/core/technicaldebt/functions/LinearFunction.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/sonar-core/src/main/java/org/sonar/core/technicaldebt/functions/LinearFunction.java b/sonar-core/src/main/java/org/sonar/core/technicaldebt/functions/LinearFunction.java index cac450e9509..2453437ddff 100644 --- a/sonar-core/src/main/java/org/sonar/core/technicaldebt/functions/LinearFunction.java +++ b/sonar-core/src/main/java/org/sonar/core/technicaldebt/functions/LinearFunction.java @@ -43,13 +43,15 @@ public class LinearFunction extends AbstractFunction { public double costInHours(TechnicalDebtRequirement requirement, Collection violations) { double points = 0.0; for (Violation violation : violations) { - points += (violation.getCost() != null ? violation.getCost() : DEFAULT_VIOLATION_COST); + Double effortToFix = violation.getCost(); + points += effortToFix != null ? effortToFix : DEFAULT_VIOLATION_COST; } return points * getConverter().toDays(requirement.getRemediationFactor()); } public long costInMinutes(TechnicalDebtRequirement requirement, Issue issue) { - double points = (issue.effortToFix() != null ? issue.effortToFix() : DEFAULT_VIOLATION_COST); + Double effortToFix = issue.effortToFix(); + double points = effortToFix != null ? effortToFix : DEFAULT_VIOLATION_COST; return Double.valueOf(points * factorInMinutes(requirement)).longValue(); } } -- 2.39.5