From d979adf975fcc3bb08b3b6ffa1cc3d97394ddd6f Mon Sep 17 00:00:00 2001 From: Sergey Budkin Date: Tue, 16 Sep 2014 14:43:03 +0300 Subject: [PATCH] Removed obsolete fix for webkit scrollbar issue. (#14203) The fix was causing a flicker effect. Initial fix for #2138 was causing a flicker effect, but the original issue is not reproducing currently even when the previous fix is reverted. Tested against tickets #3457, #3875, #7607, #6698 as well as filtering out and removing rows. Change-Id: I1aa6943eb93898d75c4e3c5b6d9326b95648bb1f --- client/src/com/vaadin/client/ui/VScrollTable.java | 11 ----------- .../com/vaadin/client/ui/table/TableConnector.java | 13 ------------- 2 files changed, 24 deletions(-) diff --git a/client/src/com/vaadin/client/ui/VScrollTable.java b/client/src/com/vaadin/client/ui/VScrollTable.java index 0def8ac69c..42fef9f0c0 100644 --- a/client/src/com/vaadin/client/ui/VScrollTable.java +++ b/client/src/com/vaadin/client/ui/VScrollTable.java @@ -6989,8 +6989,6 @@ public class VScrollTable extends FlowPanel implements HasWidgets, } } - Util.runWebkitOverflowAutoFixDeferred(scrollBodyPanel.getElement()); - forceRealignColumnHeaders(); } @@ -7119,15 +7117,6 @@ public class VScrollTable extends FlowPanel implements HasWidgets, if (initializedAndAttached) { updatePageLength(); } - if (!rendering) { - // Webkit may sometimes get an odd rendering bug (white space - // between header and body), see bug #3875. Running - // overflow hack here to shake body element a bit. - // We must run the fix as a deferred command to prevent it from - // overwriting the scroll position with an outdated value, see - // #7607. - Util.runWebkitOverflowAutoFixDeferred(scrollBodyPanel.getElement()); - } triggerLazyColumnAdjustment(false); diff --git a/client/src/com/vaadin/client/ui/table/TableConnector.java b/client/src/com/vaadin/client/ui/table/TableConnector.java index 56b35cce56..7fb4bc108a 100644 --- a/client/src/com/vaadin/client/ui/table/TableConnector.java +++ b/client/src/com/vaadin/client/ui/table/TableConnector.java @@ -198,19 +198,6 @@ public class TableConnector extends AbstractHasComponentsConnector implements uidl.getIntAttribute("rows")); if (getWidget().headerChangedDuringUpdate) { getWidget().triggerLazyColumnAdjustment(true); - } else if (!getWidget().isScrollPositionVisible() - || totalRowsHaveChanged - || getWidget().lastRenderedHeight != getWidget().scrollBody - .getOffsetHeight()) { - // webkits may still bug with their disturbing scrollbar - // bug, see #3457 - // Run overflow fix for the scrollable area - // #6698 - If there's a scroll going on, don't abort it - // by changing overflows as the length of the contents - // *shouldn't* have changed (unless the number of rows - // or the height of the widget has also changed) - Util.runWebkitOverflowAutoFixDeferred(getWidget().scrollBodyPanel - .getElement()); } } else { getWidget().initializeRows(uidl, rowData); -- 2.39.5