From de5b31829d166fca2ab477394337602017fecc85 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Teemu=20Po=CC=88ntelin?= Date: Sun, 1 Jun 2014 23:57:25 +0300 Subject: [PATCH] Fix for handling a breakpoint with 0 as the lower bound (#13588) Added explicit isNaN checks to the results of parseInt function because JavaScript would always convert 0 to false. Change-Id: Ic904c321c0195ce50d9a498005459425b0c30d4c --- .../com/vaadin/client/extensions/ResponsiveConnector.java | 6 +++--- .../src/com/vaadin/tests/extensions/ResponsiveUITest.java | 3 +++ 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/client/src/com/vaadin/client/extensions/ResponsiveConnector.java b/client/src/com/vaadin/client/extensions/ResponsiveConnector.java index b2230a4846..1392a1a49a 100644 --- a/client/src/com/vaadin/client/extensions/ResponsiveConnector.java +++ b/client/src/com/vaadin/client/extensions/ResponsiveConnector.java @@ -383,15 +383,15 @@ public class ResponsiveConnector extends AbstractExtensionConnector implements var min = parseInt(bp[1]); var max = parseInt(bp[2]); - if(min && max) { + if(!isNaN(min) && !isNaN(max)) { if(min <= size && size <= max) { ranges += " " + bp[1] + "-" + bp[2]; } - } else if (min) { + } else if (!isNaN(min)) { if(min <= size) { ranges += " " + bp[1] + "-"; } - } else if (max) { + } else if (!isNaN(max)) { if (size <= max) { ranges += " -" + bp[2]; } diff --git a/uitest/src/com/vaadin/tests/extensions/ResponsiveUITest.java b/uitest/src/com/vaadin/tests/extensions/ResponsiveUITest.java index 6827bd0a5d..f7cbd9477c 100644 --- a/uitest/src/com/vaadin/tests/extensions/ResponsiveUITest.java +++ b/uitest/src/com/vaadin/tests/extensions/ResponsiveUITest.java @@ -76,6 +76,9 @@ public class ResponsiveUITest extends MultiBrowserTest { assertEquals("-200px", $(".v-csslayout-grid.first").getAttribute("width-range")); + moveSplitter(-100); + assertEquals("0-100px", + $(".v-csslayout-grid.second").getAttribute("width-range")); } private void moveSplitter(int xOffset) { -- 2.39.5