From de6b8ddf4184b30a6588cc57e185ebc782a11693 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Leif=20=C3=85strand?= Date: Tue, 7 Feb 2012 13:19:09 +0200 Subject: [PATCH] Add VPaintableWidgetContainer.getChildren() (#8323) --- .../gwt/client/VPaintableWidgetContainer.java | 4 +- .../ui/VAbstractPaintableWidgetContainer.java | 68 ++++++++++++++----- 2 files changed, 54 insertions(+), 18 deletions(-) diff --git a/src/com/vaadin/terminal/gwt/client/VPaintableWidgetContainer.java b/src/com/vaadin/terminal/gwt/client/VPaintableWidgetContainer.java index baf266546d..da48eeb2fb 100644 --- a/src/com/vaadin/terminal/gwt/client/VPaintableWidgetContainer.java +++ b/src/com/vaadin/terminal/gwt/client/VPaintableWidgetContainer.java @@ -4,6 +4,8 @@ package com.vaadin.terminal.gwt.client; +import java.util.Collection; + import com.google.gwt.user.client.ui.HasWidgets; /** @@ -40,6 +42,6 @@ public interface VPaintableWidgetContainer extends VPaintableWidget { * @return A collection of children for this paintable. An empty collection * if there are no children. */ - // public Collection getChildren(); + public Collection getChildren(); } diff --git a/src/com/vaadin/terminal/gwt/client/ui/VAbstractPaintableWidgetContainer.java b/src/com/vaadin/terminal/gwt/client/ui/VAbstractPaintableWidgetContainer.java index 1f78c02f58..87bf245217 100644 --- a/src/com/vaadin/terminal/gwt/client/ui/VAbstractPaintableWidgetContainer.java +++ b/src/com/vaadin/terminal/gwt/client/ui/VAbstractPaintableWidgetContainer.java @@ -1,17 +1,51 @@ -/* -@VaadinApache2LicenseForJavaFiles@ - */ -package com.vaadin.terminal.gwt.client.ui; - -import com.vaadin.terminal.gwt.client.VPaintableWidgetContainer; - -public abstract class VAbstractPaintableWidgetContainer extends - VAbstractPaintableWidget implements VPaintableWidgetContainer { - - /** - * Default constructor - */ - public VAbstractPaintableWidgetContainer() { - } - -} +/* +@VaadinApache2LicenseForJavaFiles@ + */ +package com.vaadin.terminal.gwt.client.ui; + +import java.util.ArrayList; +import java.util.Collection; + +import com.google.gwt.user.client.ui.HasWidgets; +import com.google.gwt.user.client.ui.Widget; +import com.vaadin.terminal.gwt.client.VPaintableMap; +import com.vaadin.terminal.gwt.client.VPaintableWidget; +import com.vaadin.terminal.gwt.client.VPaintableWidgetContainer; + +public abstract class VAbstractPaintableWidgetContainer extends + VAbstractPaintableWidget implements VPaintableWidgetContainer { + + /** + * Default constructor + */ + public VAbstractPaintableWidgetContainer() { + } + + public Collection getChildren() { + Collection children = new ArrayList(); + + addDescendantPaintables(getWidgetForPaintable(), children, + VPaintableMap.get(getConnection())); + + return children; + } + + private static void addDescendantPaintables(Widget widget, + Collection paintables, VPaintableMap paintableMap) { + // FIXME: Store hierarchy instead of doing lookup every time + + if (widget instanceof HasWidgets) { + for (Widget child : (HasWidgets) widget) { + VPaintableWidget paintable = paintableMap.getPaintable(child); + if (paintable != null) { + // If child is a paintable, add it to the collection + paintables.add(paintable); + } else { + // Else keep looking for paintables inside the child widget + addDescendantPaintables(child, paintables, paintableMap); + } + } + } + } + +} -- 2.39.5