From e104f6cfa0324f9625c6258bb87f708d7c35d7bd Mon Sep 17 00:00:00 2001 From: MaxPower15 Date: Mon, 20 Dec 2010 08:50:23 -0500 Subject: [PATCH] Tabs: Use event.preventDefault() instead of return false. Fixes #6765 - Tabs: Use event.preventDefault() instead of returning false. --- ui/jquery.ui.tabs.js | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) mode change 100644 => 100755 ui/jquery.ui.tabs.js diff --git a/ui/jquery.ui.tabs.js b/ui/jquery.ui.tabs.js old mode 100644 new mode 100755 index 13e1c25c8..82da51d5b --- a/ui/jquery.ui.tabs.js +++ b/ui/jquery.ui.tabs.js @@ -330,7 +330,8 @@ $.widget( "ui.tabs", { }; // attach tab event handler, unbind to avoid duplicates from former tabifying... - this.anchors.bind( o.event + ".tabs", function() { + this.anchors.bind( o.event + ".tabs", function( event ) { + event.preventDefault(); var el = this, $li = $(el).closest( "li" ), $hide = self.panels.filter( ":not(.ui-tabs-hide)" ), @@ -346,7 +347,7 @@ $.widget( "ui.tabs", { self.panels.filter( ":animated" ).length || self._trigger( "select", null, self._ui( this, $show[ 0 ] ) ) === false ) { this.blur(); - return false; + return; } o.selected = self.anchors.index( this ); @@ -367,7 +368,7 @@ $.widget( "ui.tabs", { }).dequeue( "tabs" ); this.blur(); - return false; + return; } else if ( !$hide.length ) { if ( o.cookie ) { self._cookie( o.selected, o.cookie ); @@ -381,7 +382,7 @@ $.widget( "ui.tabs", { self.load( self.anchors.index( this ) ); this.blur(); - return false; + return; } } @@ -415,8 +416,8 @@ $.widget( "ui.tabs", { }); // disable click in any case - this.anchors.bind( "click.tabs", function(){ - return false; + this.anchors.bind( "click.tabs", function( event ){ + event.preventDefault(); }); }, -- 2.39.5