From e389e639741ba601b9b7ae5a963e03db23e221fe Mon Sep 17 00:00:00 2001 From: Hugo Renard Date: Thu, 18 Jan 2024 12:09:38 +0100 Subject: [PATCH] fix: always add user to group cache When there is no user in a group, and we add one, it's not added to the group cache. So consecutive call of addUser() and getUsers() is inconsistent. Furthermore, the user cache is never null, so this check is unesserary. Signed-off-by: Hugo Renard --- lib/private/Group/Group.php | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/lib/private/Group/Group.php b/lib/private/Group/Group.php index d8d1a73762d..57289a4d3ac 100644 --- a/lib/private/Group/Group.php +++ b/lib/private/Group/Group.php @@ -184,9 +184,7 @@ class Group implements IGroup { foreach ($this->backends as $backend) { if ($backend->implementsActions(\OC\Group\Backend::ADD_TO_GROUP)) { $backend->addToGroup($user->getUID(), $this->gid); - if ($this->users) { - $this->users[$user->getUID()] = $user; - } + $this->users[$user->getUID()] = $user; $this->dispatcher->dispatchTyped(new UserAddedEvent($this, $user)); -- 2.39.5