From e3b961169f23aa9b7db7e0346579042746c54935 Mon Sep 17 00:00:00 2001 From: Teryk Bellahsene Date: Thu, 8 Jan 2015 10:01:17 +0100 Subject: [PATCH] fix resource leak --- .../sonar/server/computation/AnalysisReportService.java | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/server/sonar-server/src/main/java/org/sonar/server/computation/AnalysisReportService.java b/server/sonar-server/src/main/java/org/sonar/server/computation/AnalysisReportService.java index ab4f4a87415..14e6a66458b 100644 --- a/server/sonar-server/src/main/java/org/sonar/server/computation/AnalysisReportService.java +++ b/server/sonar-server/src/main/java/org/sonar/server/computation/AnalysisReportService.java @@ -72,14 +72,14 @@ public class AnalysisReportService implements ServerComponent { void loadResources(ComputeEngineContext context) { File file = new File(context.getReportDirectory(), "components.json"); - try { - InputStream resourcesStream = new FileInputStream(file); + try (InputStream resourcesStream = new FileInputStream(file)) { String json = IOUtils.toString(resourcesStream); ReportComponents reportComponents = ReportComponents.fromJson(json); context.addResources(reportComponents); } catch (IOException e) { throw new IllegalStateException("Failed to read issues", e); } + } @VisibleForTesting @@ -97,9 +97,8 @@ public class AnalysisReportService implements ServerComponent { File issuesFile = new File(context.getReportDirectory(), "issues.json"); List issues = new ArrayList<>(MAX_ISSUES_SIZE); - try { - InputStream issuesStream = new FileInputStream(issuesFile); - JsonReader reader = new JsonReader(new InputStreamReader(issuesStream)); + try (InputStream issuesStream = new FileInputStream(issuesFile); + JsonReader reader = new JsonReader(new InputStreamReader(issuesStream))) { reader.beginArray(); while (reader.hasNext()) { ReportIssue reportIssue = gson.fromJson(reader, ReportIssue.class); -- 2.39.5