From e4fc2670d56a003677ec6f465641df08bc528883 Mon Sep 17 00:00:00 2001 From: PJ Fanning Date: Sun, 15 Oct 2017 20:50:58 +0000 Subject: [PATCH] Make public static members final [thanks to Kui Liu]. This close #78. git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812234 13f79535-47bb-0310-9956-ffa450edef68 --- .../src/org/apache/poi/hssf/view/SVTableCellRenderer.java | 2 +- src/examples/src/org/apache/poi/hssf/view/SVTableUtils.java | 2 +- .../org/apache/poi/hssf/record/common/FeatProtection.java | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/examples/src/org/apache/poi/hssf/view/SVTableCellRenderer.java b/src/examples/src/org/apache/poi/hssf/view/SVTableCellRenderer.java index ab8b1faf60..4e51ba3b72 100644 --- a/src/examples/src/org/apache/poi/hssf/view/SVTableCellRenderer.java +++ b/src/examples/src/org/apache/poi/hssf/view/SVTableCellRenderer.java @@ -52,7 +52,7 @@ import org.apache.poi.ss.usermodel.FillPatternType; public class SVTableCellRenderer extends JLabel implements TableCellRenderer, Serializable { - protected static Border noFocusBorder = new EmptyBorder(1, 1, 1, 1); + protected static final Border noFocusBorder = new EmptyBorder(1, 1, 1, 1); protected SVBorder cellBorder = new SVBorder(); diff --git a/src/examples/src/org/apache/poi/hssf/view/SVTableUtils.java b/src/examples/src/org/apache/poi/hssf/view/SVTableUtils.java index 1a9fbf813a..6a7d2fa343 100644 --- a/src/examples/src/org/apache/poi/hssf/view/SVTableUtils.java +++ b/src/examples/src/org/apache/poi/hssf/view/SVTableUtils.java @@ -41,7 +41,7 @@ public class SVTableUtils { /** Description of the Field */ public final static Color white = getAWTColor(HSSFColorPredefined.WHITE); /** Description of the Field */ - public static Border noFocusBorder = new EmptyBorder(1, 1, 1, 1); + public static final Border noFocusBorder = new EmptyBorder(1, 1, 1, 1); /** diff --git a/src/java/org/apache/poi/hssf/record/common/FeatProtection.java b/src/java/org/apache/poi/hssf/record/common/FeatProtection.java index a8dd9b36cf..f61d5ae3e4 100644 --- a/src/java/org/apache/poi/hssf/record/common/FeatProtection.java +++ b/src/java/org/apache/poi/hssf/record/common/FeatProtection.java @@ -35,8 +35,8 @@ import org.apache.poi.util.StringUtil; */ public final class FeatProtection implements SharedFeature { @SuppressWarnings("RedundantFieldInitialization") - public static long NO_SELF_RELATIVE_SECURITY_FEATURE = 0; - public static long HAS_SELF_RELATIVE_SECURITY_FEATURE = 1; + public static final long NO_SELF_RELATIVE_SECURITY_FEATURE = 0; + public static final long HAS_SELF_RELATIVE_SECURITY_FEATURE = 1; private int fSD; @@ -103,4 +103,4 @@ public final class FeatProtection implements SharedFeature { public int getFSD() { return fSD; } -} \ No newline at end of file +} -- 2.39.5