From ea331bebf218042f2557481fc3258dd4e26d8e38 Mon Sep 17 00:00:00 2001 From: aclement Date: Wed, 28 Jan 2009 00:41:57 +0000 Subject: [PATCH] refactoring to make around advice lvt fixes easier to apply - and make the code a bit clearer --- weaver/src/org/aspectj/weaver/bcel/BcelShadow.java | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/weaver/src/org/aspectj/weaver/bcel/BcelShadow.java b/weaver/src/org/aspectj/weaver/bcel/BcelShadow.java index 9db743319..2809f253f 100644 --- a/weaver/src/org/aspectj/weaver/bcel/BcelShadow.java +++ b/weaver/src/org/aspectj/weaver/bcel/BcelShadow.java @@ -2081,22 +2081,10 @@ public class BcelShadow extends Shadow { world.getLint().cantFindType.signal(new String[] { WeaverMessages.format( WeaverMessages.CANT_FIND_TYPE_DURING_AROUND_WEAVE, declaringAspectType.getClassName()) }, getSourceLocation(), new ISourceLocation[] { munger.getSourceLocation() }); - // IMessage msg = new Message( - // WeaverMessages.format(WeaverMessages.CANT_FIND_TYPE_DURING_AROUND_WEAVE,declaringType.getClassName()), - // "",IMessage.ERROR,getSourceLocation(),null, - // new ISourceLocation[]{ munger.getSourceLocation()}); - // world.getMessageHandler().handleMessage(msg); } // ??? might want some checks here to give better errors ResolvedType rt = (declaringAspectType.isParameterizedType() ? declaringAspectType.getGenericType() : declaringAspectType); BcelObjectType ot = BcelWorld.getBcelObjectType(rt); - // if (ot==null) { - // world.getMessageHandler().handleMessage( - // MessageUtil.warn("Unable to find modifiable delegate for the aspect '"+rt.getName()+ - // "' containing around advice - cannot implement inlining",munger.getSourceLocation())); - // weaveAroundClosure(munger, hasDynamicTest); - // return; - // } LazyMethodGen adviceMethod = ot.getLazyClassGen().getLazyMethodGen(mungerSig); if (!adviceMethod.getCanInline()) { weaveAroundClosure(munger, hasDynamicTest); -- 2.39.5