From ed0c23a9cc49f10c741a84dc6c95e1dfef6ee61b Mon Sep 17 00:00:00 2001 From: Bernhard Posselt Date: Thu, 2 May 2013 14:36:16 +0200 Subject: [PATCH] fix bug that would only return error responses for 3rdparty apps --- lib/api.php | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/api.php b/lib/api.php index 249d7a90350..8e4c3ef29b9 100644 --- a/lib/api.php +++ b/lib/api.php @@ -147,6 +147,7 @@ class OC_API { } } } + // Remove any error responses if there is one shipped response that succeeded if(!empty($shipped['succeeded'])) { $responses = array_merge($shipped['succeeded'], $thirdparty['succeeded']); @@ -157,14 +158,17 @@ class OC_API { // Maybe any that are not OC_API::RESPOND_SERVER_ERROR $response = reset($shipped['failed']); return $response; - } else { + } elseif(!empty($thirdparty['failed'])) { // Return the third party failure result $response = reset($thirdparty['failed']); return $response; + } else { + $responses = array_merge($shipped['succeeded'], $thirdparty['succeeded']); } // Merge the successful responses $meta = array(); $data = array(); + foreach($responses as $app => $response) { if(OC_App::isShipped($app)) { $data = array_merge_recursive($response->getData(), $data); -- 2.39.5