From f0acaac230b70b3754ef3aabe8fc90f23fbb6a88 Mon Sep 17 00:00:00 2001 From: =?utf8?q?J=C3=B6rn=20Zaefferer?= Date: Thu, 15 Nov 2012 23:12:54 +0100 Subject: [PATCH] Dialog: Refactor uiDialogTitlebar variable, use this.uiDialogTitlebar instead. Wasn't needed anymore (previous refactorings). --- ui/jquery.ui.dialog.js | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/ui/jquery.ui.dialog.js b/ui/jquery.ui.dialog.js index 24fada479..60bcca0c6 100644 --- a/ui/jquery.ui.dialog.js +++ b/ui/jquery.ui.dialog.js @@ -93,8 +93,6 @@ $.widget("ui.dialog", { var that = this, options = this.options, title = options.title || " ", - // TODO should use this.uiDialogTitlebar instead - uiDialogTitlebar, uiDialogTitle, uiDialogButtonPane; @@ -124,11 +122,11 @@ $.widget("ui.dialog", { .addClass( "ui-dialog-content ui-widget-content" ) .appendTo( this.uiDialog ); - // TODO extract this and the next three into a _createTitlebar method - uiDialogTitlebar = ( this.uiDialogTitlebar = $( "
" ) ) + // TODO extract this and the next two into a _createTitlebar method + this.uiDialogTitlebar = $( "
" ) .addClass( "ui-dialog-titlebar ui-widget-header ui-corner-all ui-helper-clearfix" ) .prependTo( this.uiDialog ); - this._on( uiDialogTitlebar, { + this._on( this.uiDialogTitlebar, { mousedown: function() { // TODO call _focusTabbable or _keepFocus // Dialog isn't getting focus when dragging (#8063) @@ -149,13 +147,13 @@ $.widget("ui.dialog", { event.preventDefault(); that.close( event ); }) - .appendTo( uiDialogTitlebar ); + .appendTo( this.uiDialogTitlebar ); uiDialogTitle = $( "" ) .uniqueId() .addClass( "ui-dialog-title" ) .html( title ) - .prependTo( uiDialogTitlebar ); + .prependTo( this.uiDialogTitlebar ); // TODO extract this one and the next into a _createButtonPane method uiDialogButtonPane = ( this.uiDialogButtonPane = $( "
" ) ) -- 2.39.5