From f82422a62e3ca42f589b9e8759f85befc0ed5181 Mon Sep 17 00:00:00 2001 From: Jean-Baptiste Lievremont Date: Fri, 7 Nov 2014 10:29:33 +0100 Subject: [PATCH] SONAR-5780 Show "Unassigned" even when count == 0 --- .../org/sonar/server/issue/ws/SearchAction.java | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/server/sonar-server/src/main/java/org/sonar/server/issue/ws/SearchAction.java b/server/sonar-server/src/main/java/org/sonar/server/issue/ws/SearchAction.java index 452280a2cf8..7d1c5067b73 100644 --- a/server/sonar-server/src/main/java/org/sonar/server/issue/ws/SearchAction.java +++ b/server/sonar-server/src/main/java/org/sonar/server/issue/ws/SearchAction.java @@ -364,15 +364,16 @@ public class SearchAction extends SearchRequestHandler { addMandatoryFacetValues(results, IssueFilterParameters.RESOLUTIONS, resolutions); addMandatoryFacetValues(results, IssueFilterParameters.PROJECT_UUIDS, request.paramAsStrings(IssueFilterParameters.PROJECT_UUIDS)); + List assignees = Lists.newArrayList(""); List assigneesFromRequest = request.paramAsStrings(IssueFilterParameters.ASSIGNEES); - if (assigneesFromRequest == null) { - assigneesFromRequest = Lists.newArrayList(); + if (assigneesFromRequest != null) { + assignees.addAll(assigneesFromRequest); } UserSession userSession = UserSession.get(); if (userSession.isLoggedIn()) { - assigneesFromRequest.add(userSession.login()); + assignees.add(userSession.login()); } - addMandatoryFacetValues(results, IssueFilterParameters.ASSIGNEES, assigneesFromRequest); + addMandatoryFacetValues(results, IssueFilterParameters.ASSIGNEES, assignees); addMandatoryFacetValues(results, IssueFilterParameters.REPORTERS, request.paramAsStrings(IssueFilterParameters.REPORTERS)); addMandatoryFacetValues(results, IssueFilterParameters.RULES, request.paramAsStrings(IssueFilterParameters.RULES)); addMandatoryFacetValues(results, IssueFilterParameters.LANGUAGES, request.paramAsStrings(IssueFilterParameters.LANGUAGES)); @@ -394,10 +395,8 @@ public class SearchAction extends SearchRequestHandler { for (FacetValue value: facetValues) { valuesByItem.put(value.getKey(), value.getValue()); } - if (mandatoryValues == null) { - mandatoryValues = Lists.newArrayList(); - } - for (String item: mandatoryValues) { + List valuesToAdd = (mandatoryValues == null ? Lists.newArrayList() : mandatoryValues); + for (String item: valuesToAdd) { if (!valuesByItem.containsKey(item)) { facetValues.add(new FacetValue(item, 0)); } -- 2.39.5