From f8719e3723661704e60c8902ab60d0a3b8b931cd Mon Sep 17 00:00:00 2001 From: Julien HENRY Date: Tue, 12 Jul 2016 12:31:13 +0200 Subject: [PATCH] Fix unclosed resource --- .../java/org/sonar/xoo/rule/NoSonarSensor.java | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/plugins/sonar-xoo-plugin/src/main/java/org/sonar/xoo/rule/NoSonarSensor.java b/plugins/sonar-xoo-plugin/src/main/java/org/sonar/xoo/rule/NoSonarSensor.java index 45d6b9dcb75..d57e2f1eb93 100644 --- a/plugins/sonar-xoo-plugin/src/main/java/org/sonar/xoo/rule/NoSonarSensor.java +++ b/plugins/sonar-xoo-plugin/src/main/java/org/sonar/xoo/rule/NoSonarSensor.java @@ -23,6 +23,7 @@ import java.io.IOException; import java.nio.file.Files; import java.util.HashSet; import java.util.Set; +import java.util.stream.Stream; import org.sonar.api.batch.Phase; import org.sonar.api.batch.fs.InputFile; import org.sonar.api.batch.sensor.Sensor; @@ -57,12 +58,14 @@ public class NoSonarSensor implements Sensor { try { Set noSonarLines = new HashSet<>(); int[] lineCounter = {1}; - Files.lines(inputFile.path(), context.fileSystem().encoding()).forEachOrdered(lineStr -> { - if (lineStr.contains("//NOSONAR")) { - noSonarLines.add(lineCounter[0]); - } - lineCounter[0]++; - }); + try (Stream stream = Files.lines(inputFile.path(), context.fileSystem().encoding())) { + stream.forEachOrdered(lineStr -> { + if (lineStr.contains("//NOSONAR")) { + noSonarLines.add(lineCounter[0]); + } + lineCounter[0]++; + }); + } noSonarFilter.noSonarInFile(inputFile, noSonarLines); } catch (IOException e) { throw new IllegalStateException("Fail to process " + inputFile, e); -- 2.39.5