From f8c9efdb31af5f02b27a68d2aabc9e18380ae2f8 Mon Sep 17 00:00:00 2001
From: Toshi MARUYAMA <marutosijp2@yahoo.co.jp>
Date: Sat, 29 Oct 2011 01:14:47 +0000
Subject: [PATCH] [#9489] linked labels to their elements

Contributed by Romano Licker.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@7679 e93f8b46-1217-0410-a6f0-8f06a7374b81
---
 app/views/issue_moves/new.html.erb  | 10 +++++-----
 app/views/issues/bulk_edit.html.erb | 22 +++++++++++-----------
 app/views/issues/index.html.erb     |  2 +-
 3 files changed, 17 insertions(+), 17 deletions(-)

diff --git a/app/views/issue_moves/new.html.erb b/app/views/issue_moves/new.html.erb
index 962a71d6c..743647ee0 100644
--- a/app/views/issue_moves/new.html.erb
+++ b/app/views/issue_moves/new.html.erb
@@ -26,17 +26,17 @@
 <%= select_tag "new_tracker_id", "<option value=\"\">#{l(:label_no_change_option)}</option>" + options_from_collection_for_select(@trackers, "id", "name") %></p>
 
 <p>
-  <label><%= l(:field_status) %></label>
+  <label for='status_id'><%= l(:field_status) %></label>
   <%= select_tag('status_id', "<option value=\"\">#{l(:label_no_change_option)}</option>" + options_from_collection_for_select(@available_statuses, :id, :name)) %>
 </p>
 
 <p>
-  <label><%= l(:field_priority) %></label>
+  <label for='priority_id'><%= l(:field_priority) %></label>
   <%= select_tag('priority_id', "<option value=\"\">#{l(:label_no_change_option)}</option>" + options_from_collection_for_select(IssuePriority.active, :id, :name)) %>
 </p>
 
 <p>
-  <label><%= l(:field_assigned_to) %></label>
+  <label for='assigned_to_id'><%= l(:field_assigned_to) %></label>
   <%= select_tag('assigned_to_id', content_tag('option', l(:label_no_change_option), :value => '') +
                                    content_tag('option', l(:label_nobody), :value => 'none') +
                                    principals_options_for_select(@target_project.assignable_users)) %>
@@ -45,12 +45,12 @@
 
 <div class="splitcontentright">
 <p>
-  <label><%= l(:field_start_date) %></label>
+  <label for='start_date'><%= l(:field_start_date) %></label>
   <%= text_field_tag 'start_date', '', :size => 10 %><%= calendar_for('start_date') %>
 </p>
 
 <p>
-  <label><%= l(:field_due_date) %></label>
+  <label for='due_date'><%= l(:field_due_date) %></label>
   <%= text_field_tag 'due_date', '', :size => 10 %><%= calendar_for('due_date') %>
 </p>
 </div>
diff --git a/app/views/issues/bulk_edit.html.erb b/app/views/issues/bulk_edit.html.erb
index df04ec969..447b9cee4 100644
--- a/app/views/issues/bulk_edit.html.erb
+++ b/app/views/issues/bulk_edit.html.erb
@@ -10,28 +10,28 @@
 
 <div class="splitcontentleft">
 <p>
-  <label><%= l(:field_tracker) %></label>
+  <label for="issue_tracker_id"><%= l(:field_tracker) %></label>
   <%= select_tag('issue[tracker_id]', "<option value=\"\">#{l(:label_no_change_option)}</option>" + options_from_collection_for_select(@trackers, :id, :name)) %>
 </p>
 <% if @available_statuses.any? %>
 <p>
-  <label><%= l(:field_status) %></label>
+  <label for='issue_status_id'><%= l(:field_status) %></label>
   <%= select_tag('issue[status_id]', "<option value=\"\">#{l(:label_no_change_option)}</option>" + options_from_collection_for_select(@available_statuses, :id, :name)) %>
 </p>
 <% end %>
 <p>
-  <label><%= l(:field_priority) %></label>
+  <label for='issue_priority_id'><%= l(:field_priority) %></label>
   <%= select_tag('issue[priority_id]', "<option value=\"\">#{l(:label_no_change_option)}</option>" + options_from_collection_for_select(IssuePriority.active, :id, :name)) %>
 </p>
 <p>
-  <label><%= l(:field_assigned_to) %></label>
+  <label for='issue_assigned_to_id'><%= l(:field_assigned_to) %></label>
   <%= select_tag('issue[assigned_to_id]', content_tag('option', l(:label_no_change_option), :value => '') +
                                  content_tag('option', l(:label_nobody), :value => 'none') +
                                  principals_options_for_select(@assignables)) %>
 </p>
 <% if @project %>
 <p>
-  <label><%= l(:field_category) %></label>
+  <label for='issue_category_id'><%= l(:field_category) %></label>
   <%= select_tag('issue[category_id]', content_tag('option', l(:label_no_change_option), :value => '') +
                                 content_tag('option', l(:label_none), :value => 'none') +
                                 options_from_collection_for_select(@project.issue_categories, :id, :name)) %>
@@ -40,7 +40,7 @@
 <% #TODO: allow editing versions when multiple projects %>
 <% if @project %>
 <p>
-  <label><%= l(:field_fixed_version) %></label>
+  <label for='issue_fixed_version_id'><%= l(:field_fixed_version) %></label>
   <%= select_tag('issue[fixed_version_id]', content_tag('option', l(:label_no_change_option), :value => '') +
                                    content_tag('option', l(:label_none), :value => 'none') +
                                    version_options_for_select(@project.shared_versions.open.sort)) %>
@@ -48,7 +48,7 @@
 <% end %>
 
 <% @custom_fields.each do |custom_field| %>
-  <p><label><%= h(custom_field.name) %></label> <%= custom_field_tag_for_bulk_edit('issue', custom_field, @projects) %></p>
+  <p><label><%= h(custom_field.name) %> <%= custom_field_tag_for_bulk_edit('issue', custom_field, @projects) %></label></p>
 <% end %>
 
 <%= call_hook(:view_issues_bulk_edit_details_bottom, { :issues => @issues }) %>
@@ -57,23 +57,23 @@
 <div class="splitcontentright">
 <% if @project && User.current.allowed_to?(:manage_subtasks, @project) %>
 <p>
-  <label><%= l(:field_parent_issue) %></label>
+  <label for='issue_parent_issue_id'><%= l(:field_parent_issue) %></label>
   <%= text_field_tag 'issue[parent_issue_id]', '', :size => 10 %>
 </p>
 <div id="parent_issue_candidates" class="autocomplete"></div>
 <%= javascript_tag "observeParentIssueField('#{auto_complete_issues_path(:project_id => @project) }')" %>
 <% end %>
 <p>
-  <label><%= l(:field_start_date) %></label>
+  <label for='issue_start_date'><%= l(:field_start_date) %></label>
   <%= text_field_tag 'issue[start_date]', '', :size => 10 %><%= calendar_for('issue_start_date') %>
 </p>
 <p>
-  <label><%= l(:field_due_date) %></label>
+  <label for='issue_due_date'><%= l(:field_due_date) %></label>
   <%= text_field_tag 'issue[due_date]', '', :size => 10 %><%= calendar_for('issue_due_date') %>
 </p>
 <% if Issue.use_field_for_done_ratio? %>
 <p>
-  <label><%= l(:field_done_ratio) %></label>
+  <label for='issue_done_ratio'><%= l(:field_done_ratio) %></label>
   <%= select_tag 'issue[done_ratio]', options_for_select([[l(:label_no_change_option), '']] + (0..10).to_a.collect {|r| ["#{r*10} %", r*10] }) %>
 </p>
 <% end %>
diff --git a/app/views/issues/index.html.erb b/app/views/issues/index.html.erb
index 2fc163e90..a5e657ec1 100644
--- a/app/views/issues/index.html.erb
+++ b/app/views/issues/index.html.erb
@@ -26,7 +26,7 @@
             <td><%= render :partial => 'queries/columns', :locals => {:query => @query} %></td>
           </tr>
           <tr>
-            <td><%= l(:field_group_by) %></td>
+            <td><label for='group_by'><%= l(:field_group_by) %></label></td>
             <td><%= select_tag('group_by', options_for_select([[]] + @query.groupable_columns.collect {|c| [c.caption, c.name.to_s]}, @query.group_by)) %></td>
           </tr>
         </table>
-- 
2.39.5