From 48d97fa8651b2bc1641e623545f870b0d9f99147 Mon Sep 17 00:00:00 2001 From: Christoph Wurst Date: Fri, 22 Oct 2021 10:41:27 +0200 Subject: [PATCH] Make the route name error more helpful As a developer I have no clue what "Invalid route name" means. If the exception gives me a hint I might find it easier to figure out why my route triggers this error. Signed-off-by: Christoph Wurst --- lib/private/AppFramework/Routing/RouteConfig.php | 2 +- lib/private/AppFramework/Routing/RouteParser.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/private/AppFramework/Routing/RouteConfig.php b/lib/private/AppFramework/Routing/RouteConfig.php index c522d3436ca..2e9f15475b7 100644 --- a/lib/private/AppFramework/Routing/RouteConfig.php +++ b/lib/private/AppFramework/Routing/RouteConfig.php @@ -131,7 +131,7 @@ class RouteConfig { $split = explode('#', $name, 2); if (count($split) !== 2) { - throw new \UnexpectedValueException('Invalid route name'); + throw new \UnexpectedValueException('Invalid route name: use the format foo#bar to reference FooController::bar'); } list($controller, $action) = $split; diff --git a/lib/private/AppFramework/Routing/RouteParser.php b/lib/private/AppFramework/Routing/RouteParser.php index 8511ff9ee39..4b1b36b7550 100644 --- a/lib/private/AppFramework/Routing/RouteParser.php +++ b/lib/private/AppFramework/Routing/RouteParser.php @@ -94,7 +94,7 @@ class RouteParser { $split = explode('#', $name, 2); if (count($split) !== 2) { - throw new \UnexpectedValueException('Invalid route name'); + throw new \UnexpectedValueException('Invalid route name: use the format foo#bar to reference FooController::bar'); } list($controller, $action) = $split; -- 2.39.5