From 0cf1fef3fa49704bef54b606390ca73bbfc9f61f Mon Sep 17 00:00:00 2001
From: libasys <sebastian.doell@libasys.de>
Date: Fri, 26 Oct 2012 20:34:04 +0200
Subject: [PATCH 1/2] Fix for problems using for() function instead of $.each
 for arrays with IE8

---
 core/js/oc-dialogs.js | 34 +++++++++++++++++++---------------
 1 file changed, 19 insertions(+), 15 deletions(-)

diff --git a/core/js/oc-dialogs.js b/core/js/oc-dialogs.js
index 2467af61121..949d8cf846e 100644
--- a/core/js/oc-dialogs.js
+++ b/core/js/oc-dialogs.js
@@ -72,33 +72,36 @@ var OCdialogs = {
 	*/
 	form:function(fields, title, callback, modal) {
 		var content = '<table>';
-		for (var a in fields) {
-			content += '<tr><td>'+fields[a].text+'</td><td>';
+		$.each(fields, function(index, val){
+			content += '<tr><td>'+val.text+'</td><td>';
 			var type=fields[a].type;
+			
 			if (type == 'text' || type == 'checkbox' || type == 'password') {
-				content += '<input type="'+type+'" name="'+fields[a].name+'"';
+				content += '<input type="'+type+'" name="'+val.name+'"';
 				if (type == 'checkbox') {
-					if (fields[a].value != undefined && fields[a].value == true) {
+					if (val.value != undefined && val.value == true) {
 						content += ' checked="checked">';
 					} else {
 						content += '>';
 					}
-				} else if (type == 'text' || type == 'password' && fields[a].value) {
-					content += ' value="'+fields[a].value+'">';
+				} else if (type == 'text' || type == 'password' && val.value) {
+					content += ' value="'+val.value+'">';
 				}
 			} else if (type == 'select') {
-				content += '<select name="'+fields[a].name+'"';
+				content += '<select name="'+val.name+'"';
 				if (fields[a].value != undefined) {
-					content += ' value="'+fields[a].value+'"';
+					content += ' value="'+val.value+'"';
 				}
 				content += '>';
-				for (var o in fields[a].options) {
-					content += '<option value="'+fields[a].options[o].value+'">'+fields[a].options[o].text+'</option>';
-				}
+				$.each(val.options, function(index, valo){
+				//for (var o in val.options) {
+					content += '<option value="'+val.valo.value+'">'+val.valo.text+'</option>';
+				});
 				content += '</select>';
 			}
 			content += '</td></tr>';
-		}
+
+		});
 		content += '</table>';
 		OCdialogs.message(content, title, OCdialogs.FORM_DIALOG, OCdialogs.OK_CANCEL_BUTTONS, callback, modal);
 	},
@@ -215,9 +218,10 @@ var OCdialogs = {
 	fillFilePicker:function(r, dialog_content_id) {
 		var entry_template = '<div onclick="javascript:OC.dialogs.handlePickerClick(this, \'*ENTRYNAME*\',\''+dialog_content_id+'\')" data="*ENTRYTYPE*"><img src="*MIMETYPEICON*" style="margin-right:1em;"><span id="filename">*NAME*</span><div style="float:right;margin-right:1em;">*LASTMODDATE*</div></div>';
 		var names = '';
-		for (var a in r.data) {
-			names += entry_template.replace('*LASTMODDATE*', OC.mtime2date(r.data[a].mtime)).replace('*NAME*', r.data[a].name).replace('*MIMETYPEICON*', r.data[a].mimetype_icon).replace('*ENTRYNAME*', r.data[a].name).replace('*ENTRYTYPE*', r.data[a].type);
-		}
+		$.each(r.data, function(index, a) {
+			names += entry_template.replace('*LASTMODDATE*', OC.mtime2date(a.mtime)).replace('*NAME*', a.name).replace('*MIMETYPEICON*', a.mimetype_icon).replace('*ENTRYNAME*', a.name).replace('*ENTRYTYPE*', a.type);
+		});
+		
 		$(dialog_content_id + ' #filelist').html(names);
 		$(dialog_content_id + ' .filepicker_loader').css('visibility', 'hidden');
 	},

From b095e3222790c1ce0421214722b737f1da94af93 Mon Sep 17 00:00:00 2001
From: libasys <sebastian.doell@libasys.de>
Date: Wed, 31 Oct 2012 09:42:26 +0100
Subject: [PATCH 2/2] UPDATE oc-dialogs.js and Fix some small Bugs Added in the
 description of form a select ecample

---
 core/js/oc-dialogs.js | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/core/js/oc-dialogs.js b/core/js/oc-dialogs.js
index 949d8cf846e..28dec97fd30 100644
--- a/core/js/oc-dialogs.js
+++ b/core/js/oc-dialogs.js
@@ -66,6 +66,7 @@ var OCdialogs = {
 	/**
 	* prompt user for input with custom form
 	* fields should be passed in following format: [{text:'prompt text', name:'return name', type:'input type', value: 'dafault value'},...]
+	* select example 	var fields=[{text:'Test', name:'test', type:'select', options:[{text:'hallo',value:1},{text:'hallo1',value:2}] }];
 	* @param fields to display 
 	* @param title dialog title
 	* @param callback which will be triggered when user press OK (user answers will be passed to callback in following format: [{name:'return name', value: 'user value'},...])
@@ -74,7 +75,7 @@ var OCdialogs = {
 		var content = '<table>';
 		$.each(fields, function(index, val){
 			content += '<tr><td>'+val.text+'</td><td>';
-			var type=fields[a].type;
+			var type=val.type;
 			
 			if (type == 'text' || type == 'checkbox' || type == 'password') {
 				content += '<input type="'+type+'" name="'+val.name+'"';
@@ -89,13 +90,12 @@ var OCdialogs = {
 				}
 			} else if (type == 'select') {
 				content += '<select name="'+val.name+'"';
-				if (fields[a].value != undefined) {
+				if (val.value != undefined) {
 					content += ' value="'+val.value+'"';
 				}
 				content += '>';
 				$.each(val.options, function(index, valo){
-				//for (var o in val.options) {
-					content += '<option value="'+val.valo.value+'">'+val.valo.text+'</option>';
+					content += '<option value="'+valo.value+'">'+valo.text+'</option>';
 				});
 				content += '</select>';
 			}