mirror of
https://github.com/nextcloud/server.git
synced 2024-09-13 15:48:32 +02:00
1466586033
The ids of permission checkboxes for shares were generated using the "shareWith" field of the share. The "shareWith" field can contain spaces (as spaces are allowed, for example, in user or circle names), so this could cause the id attribute of the HTML element to contain spaces too, which is forbidden by the HTML specification. It is not just a "formal" issue, though; when the list was rendered, if the id contained a space the selector to get the checkbox element was wrong (as it ended being something like "#canEdit-view1-name with spaces") and thus the initial state of the checkbox was not properly set. Besides that, "shareWith" can contain too single quotes, which would even cause the jQuery selector to abort the search and leave the UI in an invalid state. Instead of adding more cases to the regular expression to escape special characters and apply it too when the ids are created now the ids of permission checkboxes for shares are based on the "shareId" field instead of on "shareWith", as "shareId" is expected to always contain compatible characters. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com> |
||
|---|---|---|
| .. | ||
| ajax | ||
| Command | ||
| Controller | ||
| css | ||
| doc | ||
| fonts | ||
| img | ||
| js | ||
| l10n | ||
| Middleware | ||
| Migrations | ||
| search | ||
| skeleton | ||
| templates | ||
| vendor | ||
| Application.php | ||
| register_command.php | ||
| routes.php | ||
| shipped.json | ||
| strings.php | ||