Mirrors/sonarqube
1
0
Fork 0
mirror of https://github.com/SonarSource/sonarqube.git synced 2024-09-13 15:45:52 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity

SONAR-8119 Correctly display rating conditions in quality gates and in project dashboard

Browse Source
This commit is contained in:
Stas Vilchik 2016-09-21 17:53:21 +02:00 committed by Julien Lancelot
parent 7bedbecd02
commit 2bd1401370
3 changed files with 13 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
server/sonar-web/src/main/js/apps/overview/qualityGate/QualityGateCondition.js
View File

@ -41,6 +41,10 @@ const QualityGateCondition = ({ component, periods, condition }) => {
const periodLabel = getPeriodLabel(period);
const periodDate = getPeriodDate(period);
const operator = metric.type === 'RATING' ?
translate('quality_gates.operator', condition.op, 'rating') :
translate('quality_gates.operator', condition.op, 'short');
return (
<li className="overview-quality-gate-condition">
<div className="overview-quality-gate-condition-period">
@ -65,7 +69,7 @@ const QualityGateCondition = ({ component, periods, condition }) => {
{metric.name}
</div>
<div className="overview-quality-gate-condition-threshold">
{translate('quality_gates.operator', condition.op, 'short')}
{operator}
{' '}
{formatMeasure(threshold, metric.type)}
</div>

8
server/sonar-web/src/main/js/apps/quality-gates/components/Condition.js
View File

@ -153,10 +153,10 @@ export default class Condition extends Component {
const isLeakSelected = !!this.state.period;
const operators = ['LT', 'GT', 'EQ', 'NE'];
const operatorOptions = operators.map(op => {
return {
label: translate('quality_gates.operator', op),
value: op
};
const label = metric.type === 'RATING' ?
translate('quality_gates.operator', op, 'rating') :
translate('quality_gates.operator', op);
return { label, value: op };
});
return (

4
sonar-core/src/main/resources/org/sonar/l10n/core.properties
View File

@ -2802,6 +2802,10 @@ quality_gates.operator.LT.short=<
quality_gates.operator.GT.short=>
quality_gates.operator.EQ.short==
quality_gates.operator.NE.short=\u2260
quality_gates.operator.LT.rating=is better than
quality_gates.operator.GT.rating=is worse than
quality_gates.operator.EQ.rating=is
quality_gates.operator.NE.rating=is not
quality_gates.delete.confirm.message=Are you sure you want to delete the "{0}" quality gate?
quality_gates.delete.confirm.default=Are you sure you want to delete the "{0}" quality gate, which is the default quality gate?
quality_gates.delete_condition=Delete Condition