Mirrors/sonarqube
1
0
Fork 0
mirror of https://github.com/SonarSource/sonarqube.git synced 2024-08-03 08:18:00 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix Clover coverage on new code at project and package levels

Browse Source
This commit is contained in:
simonbrandhof 2011-03-23 15:31:47 +01:00
parent 1d414016d3
commit b25c800108
1 changed files with 21 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
plugins/sonar-core-plugin/src/main/java/org/sonar/plugins/core/sensors/AbstractCoverageDecorator.java
View File

@ -50,32 +50,36 @@ public abstract class AbstractCoverageDecorator implements Decorator {
}
protected boolean shouldDecorate(final Resource resource, final DecoratorContext context) {
return context.getMeasure(getGeneratedMetric()) == null && !ResourceUtils.isUnitTestClass(resource);
return !ResourceUtils.isUnitTestClass(resource);
}
private void computeMeasure(DecoratorContext context) {
Long elements = countElements(context);
if (elements != null && elements > 0L) {
Long coveredElements = countCoveredElements(context);
context.saveMeasure(getGeneratedMetric(), calculateCoverage(coveredElements, elements));
if (context.getMeasure(getGeneratedMetric()) == null) {
Long elements = countElements(context);
if (elements != null && elements > 0L) {
Long coveredElements = countCoveredElements(context);
context.saveMeasure(getGeneratedMetric(), calculateCoverage(coveredElements, elements));
}
}
}
private void computeMeasureForNewCode(DecoratorContext context) {
Measure measure = new Measure(getGeneratedMetricForNewCode());
boolean hasValue = false;
/* TODO remove this magic number */
for (int periodIndex = 1; periodIndex <= 5; periodIndex++) {
Long elements = countElementsForNewCode(context, periodIndex);
if (context.getMeasure(getGeneratedMetricForNewCode()) == null) {
Measure measure = new Measure(getGeneratedMetricForNewCode());
boolean hasValue = false;
/* TODO remove this magic number */
for (int periodIndex = 1; periodIndex <= 5; periodIndex++) {
Long elements = countElementsForNewCode(context, periodIndex);
if (elements != null && elements > 0L) {
long coveredElements = countCoveredElementsForNewCode(context, periodIndex);
measure.setVariation(periodIndex, calculateCoverage(coveredElements, elements));
hasValue = true;
if (elements != null && elements > 0L) {
long coveredElements = countCoveredElementsForNewCode(context, periodIndex);
measure.setVariation(periodIndex, calculateCoverage(coveredElements, elements));
hasValue = true;
}
}
if (hasValue) {
context.saveMeasure(measure);
}
}
if (hasValue) {
context.saveMeasure(measure);
}
}