Fix scheduling of ViolationDecorator

ViolationPersisterDecorator must be executed before computing measures on violations, so the flag switched_off is correctly loaded from database.
This commit is contained in:
simonbrandhof 2011-04-27 23:41:28 +02:00
parent ec6b3ca5ae
commit f4e12a9527
4 changed files with 8 additions and 4 deletions

View File

@ -31,11 +31,12 @@ import org.sonar.api.database.model.Snapshot;
import org.sonar.api.resources.Project;
import org.sonar.api.resources.Resource;
import org.sonar.batch.index.ResourcePersister;
import org.sonar.plugins.core.timemachine.ViolationPersisterDecorator;
/**
* Decorator that currently only closes a review when its corresponding violation has been fixed.
*/
@DependsUpon("ViolationPersisterDecorator")
@DependsUpon(ViolationPersisterDecorator.BARRIER)
public class CloseReviewsDecorator implements Decorator {
private static final Logger LOG = LoggerFactory.getLogger(CloseReviewsDecorator.class);

View File

@ -30,13 +30,14 @@ import org.sonar.api.resources.ResourceUtils;
import org.sonar.api.rules.Rule;
import org.sonar.api.rules.RulePriority;
import org.sonar.api.rules.Violation;
import org.sonar.plugins.core.timemachine.ViolationPersisterDecorator;
import java.util.Arrays;
import java.util.Collection;
import java.util.List;
import java.util.Map;
@DependsUpon(value = DecoratorBarriers.END_OF_VIOLATIONS_GENERATION)
@DependsUpon(value = ViolationPersisterDecorator.BARRIER)
public class ViolationsDecorator implements Decorator {
// temporary data for current resource

View File

@ -39,7 +39,7 @@ import org.sonar.batch.components.TimeMachineConfiguration;
import java.util.*;
/* temporary workaround - the attributes classes() should be used but it is buggy */
@DependsUpon("ViolationPersisterDecorator")
@DependsUpon(ViolationPersisterDecorator.BARRIER)
public class NewViolationsDecorator implements Decorator {
private TimeMachineConfiguration timeMachineConfiguration;

View File

@ -45,10 +45,12 @@ import com.google.common.collect.Lists;
import com.google.common.collect.Multimap;
@DependsUpon(DecoratorBarriers.END_OF_VIOLATIONS_GENERATION)
@DependedUpon("ViolationPersisterDecorator")
@DependedUpon(ViolationPersisterDecorator.BARRIER)
/* temporary workaround - see NewViolationsDecorator */
public class ViolationPersisterDecorator implements Decorator {
public static final String BARRIER = "ViolationPersisterDecorator";
/**
* Those chars would be ignored during generation of checksums.
*/