diff options
author | aclement <aclement> | 2006-02-24 12:11:15 +0000 |
---|---|---|
committer | aclement <aclement> | 2006-02-24 12:11:15 +0000 |
commit | a116142da250286f414946a76112c907e59c6beb (patch) | |
tree | f2fa66723e1aff47f737ce874023e05519c90600 | |
parent | 49e1a631d84ca65e387e5e3d0923e322bb9d2c76 (diff) | |
download | aspectj-a116142da250286f414946a76112c907e59c6beb.tar.gz aspectj-a116142da250286f414946a76112c907e59c6beb.zip |
optimization 129298 - remove redundant (expensive) field - from Ron, doing what I suggested in a comment against the field ;)
-rw-r--r-- | weaver/src/org/aspectj/weaver/JoinPointSignature.java | 4 | ||||
-rw-r--r-- | weaver/src/org/aspectj/weaver/Member.java | 3 | ||||
-rw-r--r-- | weaver/src/org/aspectj/weaver/MemberImpl.java | 11 |
3 files changed, 0 insertions, 18 deletions
diff --git a/weaver/src/org/aspectj/weaver/JoinPointSignature.java b/weaver/src/org/aspectj/weaver/JoinPointSignature.java index 0b10f7541..b7bb04c3c 100644 --- a/weaver/src/org/aspectj/weaver/JoinPointSignature.java +++ b/weaver/src/org/aspectj/weaver/JoinPointSignature.java @@ -267,10 +267,6 @@ public class JoinPointSignature implements ResolvedMember { return realMember.getSignature(); } - public String getDeclaredSignature() { - return realMember.getDeclaredSignature(); - } - public int getArity() { return realMember.getArity(); } diff --git a/weaver/src/org/aspectj/weaver/Member.java b/weaver/src/org/aspectj/weaver/Member.java index 76f3e06d3..24f4224f3 100644 --- a/weaver/src/org/aspectj/weaver/Member.java +++ b/weaver/src/org/aspectj/weaver/Member.java @@ -80,9 +80,6 @@ public interface Member { */ public Iterator getJoinPointSignatures(World world); - /** TODO ASC Should return the non-erased version of the signature... untested */ - public String getDeclaredSignature(); - public int getArity(); /** diff --git a/weaver/src/org/aspectj/weaver/MemberImpl.java b/weaver/src/org/aspectj/weaver/MemberImpl.java index 5f0c6ff55..039210378 100644 --- a/weaver/src/org/aspectj/weaver/MemberImpl.java +++ b/weaver/src/org/aspectj/weaver/MemberImpl.java @@ -30,7 +30,6 @@ public class MemberImpl implements Comparable, AnnotatedElement,Member { protected String name; protected UnresolvedType[] parameterTypes; private final String signature; - private final String declaredSignature; // TODO asc Is this redundant? Is it needed for generics? private String paramSignature; /** @@ -52,7 +51,6 @@ public class MemberImpl implements Comparable, AnnotatedElement,Member { this.modifiers = modifiers; this.name = name; this.signature = signature; - this.declaredSignature = signature; if (kind == FIELD) { this.returnType = UnresolvedType.forSignature(signature); this.parameterTypes = UnresolvedType.NONE; @@ -83,10 +81,8 @@ public class MemberImpl implements Comparable, AnnotatedElement,Member { this.parameterTypes = parameterTypes; if (kind == FIELD) { this.signature = returnType.getErasureSignature(); - this.declaredSignature = returnType.getSignature(); } else { this.signature = typesToSignature(returnType, parameterTypes,true); - this.declaredSignature = typesToSignature(returnType,parameterTypes,false); } } @@ -476,13 +472,6 @@ public class MemberImpl implements Comparable, AnnotatedElement,Member { */ public String getSignature() { return signature; } - /* (non-Javadoc) - * @see org.aspectj.weaver.Member#getDeclaredSignature() - */ - public String getDeclaredSignature() { return declaredSignature;} - /* (non-Javadoc) - * @see org.aspectj.weaver.Member#getArity() - */ public int getArity() { return parameterTypes.length; } /* (non-Javadoc) |