aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAlexander Kriegisch <Alexander@Kriegisch.name>2022-03-23 08:43:57 +0700
committerAlexander Kriegisch <Alexander@Kriegisch.name>2022-03-23 08:43:57 +0700
commit5288ef1c1c8be2df85e59740f41622f4cfb9d899 (patch)
tree3386b3e8bea51daf6d4cf09df6cdd29db3084c3e
parenta385d8b6613b4dbdce81880a84cd709fb09026d6 (diff)
downloadaspectj-5288ef1c1c8be2df85e59740f41622f4cfb9d899.tar.gz
aspectj-5288ef1c1c8be2df85e59740f41622f4cfb9d899.zip
AtAjLTWTests: 4 test cases switched to 'useFullLTW' mode
After the Java 18 JDT Core upgrade, some LTW tests are failing and have to be switched from in-process to full LTW mode due to them now obviously calling some code paths which need '--add-opens'. Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
-rw-r--r--tests/src/test/java/org/aspectj/systemtest/ajc150/ataspectj/AtAjLTWTests.java7
-rw-r--r--tests/src/test/resources/org/aspectj/systemtest/ajc150/ataspectj/ltw.xml20
2 files changed, 14 insertions, 13 deletions
diff --git a/tests/src/test/java/org/aspectj/systemtest/ajc150/ataspectj/AtAjLTWTests.java b/tests/src/test/java/org/aspectj/systemtest/ajc150/ataspectj/AtAjLTWTests.java
index c7be1944c..e06a3b0c3 100644
--- a/tests/src/test/java/org/aspectj/systemtest/ajc150/ataspectj/AtAjLTWTests.java
+++ b/tests/src/test/java/org/aspectj/systemtest/ajc150/ataspectj/AtAjLTWTests.java
@@ -121,11 +121,12 @@ public class AtAjLTWTests extends XMLBasedAjcTestCase {
public void testLTWDumpClosure() {
runTest("LTW DumpTest closure");
- File f = new File("_ajdump/ataspectj/DumpTestTheDump$AjcClosure1.class");
+ // Test runs with 'usefullltw="true"' -> dump files are created in the sandbox directory
+ File f = new File(ajc.getSandboxDirectory() + "/_ajdump/ataspectj/DumpTestTheDump$AjcClosure1.class");
assertTrue("Missing dump file " + f.getAbsolutePath(), f.exists());
- // tidy up...
- f = new File("_ajdump");
+ // tidy up... (should not be necessary in sandbox directory, but does not hurt)
+ f = new File(ajc.getSandboxDirectory() + "/_ajdump");
FileUtil.deleteContents(f);
f.delete();
}
diff --git a/tests/src/test/resources/org/aspectj/systemtest/ajc150/ataspectj/ltw.xml b/tests/src/test/resources/org/aspectj/systemtest/ajc150/ataspectj/ltw.xml
index a72fa4ebf..9dfc4afe4 100644
--- a/tests/src/test/resources/org/aspectj/systemtest/ajc150/ataspectj/ltw.xml
+++ b/tests/src/test/resources/org/aspectj/systemtest/ajc150/ataspectj/ltw.xml
@@ -95,7 +95,7 @@
options="-1.5"/>
<run class="ataspectj.DumpTest" ltw="ataspectj/aop-dump.xml"/>
</ajc-test>
-
+
<ajc-test dir="java5/ataspectj" title="LTW DumpTest before and after">
<compile
files="ataspectj/EmptyAspect.aj"
@@ -123,7 +123,7 @@
<compile
files="ataspectj/DumpTest.java,ataspectj/DumpTestTheDump.java,ataspectj/TestAroundAspect.aj"
options="-1.5"/>
- <run class="ataspectj.DumpTest" ltw="ataspectj/aop-dumpclosure.xml"/>
+ <run class="ataspectj.DumpTest" ltw="ataspectj/aop-dumpclosure.xml" usefullltw="true"/>
</ajc-test>
<ajc-test dir="java5/ataspectj" title="LTW DumpTest proxy">
@@ -163,7 +163,7 @@
files="ataspectj/ltwlog/Aspect1.java"
options="-1.5 -XterminateAfterCompilation"
>
- </compile>
+ </compile>
<run class="ataspectj.ltwlog.Main" ltw="ataspectj/ltwlog/aop-silent.xml">
<stdout>
<line text="execution(Main.target())"/>
@@ -182,7 +182,7 @@
files="ataspectj/ltwlog/Aspect1.java"
options="-1.5 -XterminateAfterCompilation"
>
- </compile>
+ </compile>
<run class="ataspectj.ltwlog.Main" ltw="ataspectj/ltwlog/aop-verbose.xml">
<stdout>
<line text="execution(Main.target())"/>
@@ -207,7 +207,7 @@
files="ataspectj/ltwlog/Aspect1.java"
options="-1.5 -XterminateAfterCompilation"
>
- </compile>
+ </compile>
<run class="ataspectj.ltwlog.Main" ltw="ataspectj/ltwlog/aop-verboseandshow.xml">
<stdout>
<line text="execution(Main.target())"/>
@@ -233,7 +233,7 @@
files="ataspectj/ltwlog/Aspect1.java"
options="-1.5 -XterminateAfterCompilation"
>
- </compile>
+ </compile>
<run class="ataspectj.ltwlog.Main" ltw="ataspectj/ltwlog/aop-messagehandler.xml">
<stdout>
<line text="MessageHolder.MessageHolder()"/>
@@ -290,7 +290,7 @@
files="ataspectj/ConcreteAtAspectTest.java,ataspectj/TestHelper.java"
options="-1.5 -XterminateAfterCompilation"
/>
- <run class="ataspectj.ConcreteAtAspectTest" ltw="ataspectj/aop-concreteataspect.xml"/>
+ <run class="ataspectj.ConcreteAtAspectTest" ltw="ataspectj/aop-concreteataspect.xml" usefullltw="true"/>
</ajc-test>
<ajc-test dir="java5/ataspectj" title="ConcreteAspect">
@@ -298,7 +298,7 @@
files="ataspectj/ConcreteAspectTest.aj,ataspectj/TestHelper.java"
options="-1.5 -Xdev:NoAtAspectJProcessing -XterminateAfterCompilation"
/>
- <run class="ataspectj.ConcreteAspectTest" ltw="ataspectj/aop-concreteaspect.xml"/>
+ <run class="ataspectj.ConcreteAspectTest" ltw="ataspectj/aop-concreteaspect.xml" usefullltw="true"/>
</ajc-test>
<ajc-test dir="java5/ataspectj" title="ConcretePrecedenceAspect">
@@ -306,7 +306,7 @@
files="ataspectj/ConcretePrecedenceAspectTest.java,ataspectj/TestHelper.java"
options="-1.5 -Xdev:NoAtAspectJProcessing -XterminateAfterCompilation"
/>
- <run class="ataspectj.ConcretePrecedenceAspectTest" ltw="ataspectj/aop-concreteprecedenceaspect.xml"/>
+ <run class="ataspectj.ConcretePrecedenceAspectTest" ltw="ataspectj/aop-concreteprecedenceaspect.xml" usefullltw="true"/>
</ajc-test>
<ajc-test dir="java5/ataspectj" title="AspectOfWhenAspectNotInInclude">
@@ -346,4 +346,4 @@
</ajc-test>
-</suite> \ No newline at end of file
+</suite>