Unnecessary boxing

Reports explicit boxing, i.e. wrapping of primitive values in objects. Explicit manual boxing is unnecessary under Java 5 and newer, and can be safely removed.

Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>

2 files changed, 3 insertions, 3 deletions

diff --git a/bcel-builder/src/main/java/org/aspectj/apache/bcel/classfile/ConstantPool.java b/bcel-builder/src/main/java/org/aspectj/apache/bcel/classfile/ConstantPool.java
index 0430e28ba..410891212 100644
--- a/bcel-builder/src/main/java/org/aspectj/apache/bcel/classfile/ConstantPool.java
+++ b/bcel-builder/src/main/java/org/aspectj/apache/bcel/classfile/ConstantPool.java
@@ -465,7 +465,7 @@ public class ConstantPool implements Node {
 				String typeSignature = ((ConstantUtf8) pool[cnat.getSignatureIndex()]).getValue();
 				if (!typeSignature.equals(searchSignature))
 					continue;
-				fieldCache.put(k, new Integer(i));
+				fieldCache.put(k, i);
 				return i;
 			}
 		}
@@ -793,7 +793,7 @@ public class ConstantPool implements Node {
 				String typeSignature = ((ConstantUtf8) pool[cnat.getSignatureIndex()]).getValue();
 				if (!typeSignature.equals(searchSignature))
 					continue;
-				methodCache.put(key, new Integer(i));
+				methodCache.put(key, i);
 				return i;
 			}
 		}
diff --git a/bcel-builder/src/main/java/org/aspectj/apache/bcel/generic/Instruction.java b/bcel-builder/src/main/java/org/aspectj/apache/bcel/generic/Instruction.java
index 113be06ee..3fa40ac0f 100644
--- a/bcel-builder/src/main/java/org/aspectj/apache/bcel/generic/Instruction.java
+++ b/bcel-builder/src/main/java/org/aspectj/apache/bcel/generic/Instruction.java
@@ -342,7 +342,7 @@ public class Instruction implements Cloneable, Serializable, Constants {
 		case ICONST_3:
 		case ICONST_4:
 		case ICONST_5:
-			return new Integer(opcode - ICONST_0);
+			return opcode - ICONST_0;
 		default:
 			throw new IllegalStateException("Not implemented yet for " + getName());
 		}