diff options
| author | Alexander Kriegisch <Alexander@Kriegisch.name> | 2021-03-20 18:37:22 +0700 |
|---|---|---|
| committer | Alexander Kriegisch <Alexander@Kriegisch.name> | 2021-03-21 02:01:18 +0700 |
| commit | a1867b05ba6443d32abc4049c26b92fc226d6f78 (patch) | |
| tree | 451e969e0aa7c5998d84cdce0d43f3f1a32d1461 /run-all-junit-tests | |
| parent | fa8369ebb82cd9668943173b4f04868b55ab4260 (diff) | |
| download | aspectj-a1867b05ba6443d32abc4049c26b92fc226d6f78.tar.gz aspectj-a1867b05ba6443d32abc4049c26b92fc226d6f78.zip | |
Remove module 'run-all-junit-tests' from root POM -> speed up the build
This module must be a relic from a test runner module once existing
during the Ant build era, but transferred and kept alive in the Maven
build. Actually, it almost doubles build time by running virtually all
tests in all modules again when doing 'mvn test' from the project root.
For now I only removed the module from the root POM, leaving behind
comments there, in the module POM and in the now @Deprecated class
RunTheseBeforeYouCommitTests.
Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
Diffstat (limited to 'run-all-junit-tests')
| -rw-r--r-- | run-all-junit-tests/pom.xml | 15 | ||||
| -rw-r--r-- | run-all-junit-tests/src/test/java/RunTheseBeforeYouCommitTests.java | 3 |
2 files changed, 13 insertions, 5 deletions
diff --git a/run-all-junit-tests/pom.xml b/run-all-junit-tests/pom.xml index 97347e3eb..b55f3b273 100644 --- a/run-all-junit-tests/pom.xml +++ b/run-all-junit-tests/pom.xml @@ -9,6 +9,11 @@ <version>1.9.7.BUILD-SNAPSHOT</version> </parent> + <!-- + These are redundant, making almost all tests run 2x. You can still open and run the module manually for now. + But why not just run 'mvn test' on top level? + TODO: After feedback from Andy Clement, probably just remove the whole module. + --> <artifactId>run-all-junit-tests</artifactId> <packaging>jar</packaging> <name>run-all-junit-tests</name> @@ -270,11 +275,11 @@ </dependencies> - <!-- <build> <pluginManagement> <plugins> <plugin> <groupId>org.apache.maven.plugins</groupId> - <artifactId>maven-compiler-plugin</artifactId> <configuration> <source>1.8</source> - <target>1.8</target> </configuration> </plugin> <plugin> <groupId>org.apache.maven.plugins</groupId> - <artifactId>maven-surefire-plugin</artifactId> <configuration> <testFailureIgnore>true</testFailureIgnore> - <includes> <include>**/RunTheseBeforeYouCommitTests*</include> </includes> + <!-- <build> <pluginManagement> <plugins> <plugin> <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-compiler-plugin</artifactId> <configuration> <source>1.8</source> + <target>1.8</target> </configuration> </plugin> <plugin> <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-surefire-plugin</artifactId> <configuration> <testFailureIgnore>true</testFailureIgnore> + <includes> <include>**/RunTheseBeforeYouCommitTests*</include> </includes> </configuration> </plugin> </plugins> </pluginManagement> </build> --> </project> diff --git a/run-all-junit-tests/src/test/java/RunTheseBeforeYouCommitTests.java b/run-all-junit-tests/src/test/java/RunTheseBeforeYouCommitTests.java index 4515959c9..6a55f133d 100644 --- a/run-all-junit-tests/src/test/java/RunTheseBeforeYouCommitTests.java +++ b/run-all-junit-tests/src/test/java/RunTheseBeforeYouCommitTests.java @@ -30,8 +30,11 @@ import junit.framework.Test; import junit.framework.TestSuite; /** + * TODO: Remove this class along with the whole module. Run 'mvn test' at the project root instead. + * * @author Andy Clement */ +@Deprecated public class RunTheseBeforeYouCommitTests { public static Test suite() { |