Fix #366085 concerning declared annotations with source retention

See https://bugs.eclipse.org/bugs/show_bug.cgi?id=366085.
See https://stackoverflow.com/q/74618269/1082681.

The issue described in the Bugzilla issue is about 'declare @type', but
similar issues also existed for 'declare @field', 'declare @method',
'declare @constructor'. This fix is rather superficial and leaves
things to be desired, because it is rather hacky and simply ignores
errors source retention annotation declarations during weaving. A better
fix would drop the corresponding declarations while parsing and also
issue compiler warnings in each case.

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>

4 files changed, 32 insertions, 0 deletions

diff --git a/tests/bugs1919/366085/Application.java b/tests/bugs1919/366085/Application.java
new file mode 100644
index 000000000..3ef2126fd
--- /dev/null
+++ b/tests/bugs1919/366085/Application.java
@@ -0,0 +1,11 @@
+public class Application {
+  public int number;
+
+  public Application(int number) {
+    this.number = number;
+  }
+
+  public int getNumber() {
+    return number;
+  }
+}
diff --git a/tests/bugs1919/366085/DeclareAnnotationsAspect.aj b/tests/bugs1919/366085/DeclareAnnotationsAspect.aj
new file mode 100644
index 000000000..8fdc9460c
--- /dev/null
+++ b/tests/bugs1919/366085/DeclareAnnotationsAspect.aj
@@ -0,0 +1,13 @@
+public aspect DeclareAnnotationsAspect {
+  // These should be ignored, because @ToString has SOURCE retention
+  declare @type : Application : @ToString;
+  declare @method : * Application.*(..) : @ToString;
+  declare @constructor : Application.new(..) : @ToString;
+  declare @field : * Application.* : @ToString;
+
+  // These should be applied, because @Marker has RUNTIME retention
+  declare @type : Application : @Marker;
+  declare @method : * Application.*(..) : @Marker;
+  declare @constructor : Application.new(..) : @Marker;
+  declare @field : * Application.* : @Marker;
+}
diff --git a/tests/bugs1919/366085/Marker.java b/tests/bugs1919/366085/Marker.java
new file mode 100644
index 000000000..42ba9af15
--- /dev/null
+++ b/tests/bugs1919/366085/Marker.java
@@ -0,0 +1,4 @@
+import java.lang.annotation.Retention;
+import java.lang.annotation.RetentionPolicy;
+@Retention(RetentionPolicy.RUNTIME)
+public @interface Marker { }
diff --git a/tests/bugs1919/366085/ToString.java b/tests/bugs1919/366085/ToString.java
new file mode 100644
index 000000000..08e9399c4
--- /dev/null
+++ b/tests/bugs1919/366085/ToString.java
@@ -0,0 +1,4 @@
+import java.lang.annotation.Retention;
+import java.lang.annotation.RetentionPolicy;
+@Retention(RetentionPolicy.SOURCE)
+public @interface ToString { }