aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Weaken Collection declarationsLars Grefer2020-08-1580-199/+193
| | | | | | Reports on declarations of Collection variables made by using the collection class as the type, rather than an appropriate interface. Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
* Redundant Collection.addAll() callLars Grefer2020-08-1528-78/+41
| | | | | | Reports Collection.addAll() and Map.putAll() calls after instantiation of a collection using a constructor call without arguments. Such constructs can be replaced with a single call to a parametrized constructor which simplifies code. Also for some collections the replacement might be more performant. Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
* Collection.toArray() call styleLars Grefer2020-08-1529-40/+40
| | | | | | | There are two styles to convert a collection to an array: either using a pre-sized array (like c.toArray(new String[c.size()])) or using an empty array (like c.toArray(new String[0]). In older Java versions using pre-sized array was recommended, as the reflection call which is necessary to create an array of proper size was quite slow. However since late updates of OpenJDK 6 this call was intrinsified, making the performance of the empty array version the same and sometimes even better, compared to the pre-sized version. Also passing pre-sized array is dangerous for a concurrent or synchronized collection as a data race is possible between the size and toArray call which may result in extra nulls at the end of the array, if the collection was concurrently shrunk during the operation. Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
* Single Map method can be usedLars Grefer2020-08-154-30/+6
| | | | | | Reports common usage patterns of java.util.Map that could be replaced with Java 8 methods: getOrDefault(), computeIfAbsent(), putIfAbsent(), merge(), or replaceAll(). Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
* Manual array copyLars Grefer2020-08-156-69/+29
| | | | | | Reports the manual copying of array contents which may be replaced by calls to System.arraycopy(). Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
* Collections.sort() can be replaced with List.sort()Lars Grefer2020-08-1512-17/+17
| | | | | | Reports calls to Collections.sort(list, comparator) which could be replaced with list.sort(comparator). Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
* Replace List.indexOf() with List.contains()Lars Grefer2020-08-151-1/+1
| | | | Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
* Manual array to collection copyLars Grefer2020-08-1511-72/+20
| | | | | | Reports the copying of array contents to a collection where each element is added individually using a for loop. Such constructs may be replaced by a call to Collection.addAll(Arrays.asList()) or Collections.addAll(). Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
* Fix the serial version UID contribution to work properlyAndy Clement2020-08-141-126/+126
|
* lets have maven fail if those tests fail...Andy Clement2020-08-1419-70/+90
|
* typoAndy Clement2020-08-141-1/+1
|
* Merge pull request #5 from larsgrefer/remove-old-version-checksAndy Clement2020-08-1427-367/+196
|\ | | | | Remove checks for old Java Versions
| * Merge branch 'master' of github.com:eclipse/org.aspectj into ↵Lars Grefer2020-08-141-2/+2
| |\ | |/ |/| | | remove-old-version-checks
* | Test on LTS versions and most recent non LTSAndy Clement2020-08-141-2/+2
| |
| * Merge branch 'master' of github.com:eclipse/org.aspectj into ↵Lars Grefer2020-08-1422-398/+371
| |\ | |/ |/| | | remove-old-version-checks
* | Merge pull request #4 from larsgrefer/feature/github-actionsAndy Clement2020-08-144-91/+9
|\ \ | | | | | | Fix and improve the CI Jobs
| * \ Merge branch 'master' of github.com:eclipse/org.aspectj into ↵Lars Grefer2020-08-1417-205/+247
| |\ \ | |/ / |/| | | | | | | | | | | feature/github-actions Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
* | | Fix up tests and reduce verbosity on J11Andy Clement2020-08-1413-198/+230
| | |
* | | Attempting to get J11 build happy at githubAndy Clement2020-08-131-4/+0
| | |
* | | Making tests behave on 11Andy Clement2020-08-134-5/+19
| | |
| * | Merge branch 'feature/simplify-ajdoc' of github.com:larsgrefer/org.aspectj ↵Lars Grefer2020-08-147-196/+123
| |\ \ | | | | | | | | | | | | | | | | | | | | into feature/github-actions Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
| | * | Always run javadoc using the ToolProvider APILars Grefer2020-08-142-87/+4
| |/ / |/| | | | | | | | | | | | | | `com.sun.tools.javadoc.Main` isn't available in recent Java versions (13+) Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
* | | Trying to reduce test verbosityAndy Clement2020-08-134-103/+116
| | |
| * | Fix compilation of JavadocRunner for Java 13+Lars Grefer2020-08-131-5/+7
| | | | | | | | | | | | Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
| * | Fix JRockitAgentTest for Java 9 and 10Lars Grefer2020-08-131-1/+1
| | | | | | | | | | | | Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
| * | Test more Java versionsLars Grefer2020-08-131-1/+2
| | | | | | | | | | | | Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
| * | Print used tool versionsLars Grefer2020-08-131-0/+2
| | | | | | | | | | | | Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
| * | Fix compilation on Java 11Lars Grefer2020-08-131-4/+4
| | | | | | | | | | | | Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
| | * Simplify checks for Java 8 to trueLars Grefer2020-08-145-132/+40
| | | | | | | | | | | | Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
| | * Remove checks for old Java VersionsLars Grefer2020-08-1324-236/+157
| |/ |/| | | | | Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
* | Adjust ASM version number used to work properly with Records (J14)Andy Clement2020-08-131-2/+3
|/
* Merge pull request #3 from larsgrefer/feature/github-actionsAndy Clement2020-08-133-6/+35
|\ | | | | Create a simple CI Job using GitHub Actions
| * Fix Javadoc generation on Java 11Lars Grefer2020-08-131-0/+1
| | | | | | | | Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
| * Fix TestcaseLars Grefer2020-08-131-6/+8
| | | | | | | | Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
| * Create maven.ymlLars Grefer2020-08-131-0/+26
| | | | | | | | Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
* | Merge pull request #2 from larsgrefer/feature/diamond-operatorAndy Clement2020-08-13243-1046/+1046
|\ \ | |/ |/| Use the diamond operator where possible
| * Use the diamond operator where possibleLars Grefer2020-08-13243-1046/+1046
|/ | | | Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
* Merge pull request #1 from larsgrefer/feature/java5Andy Clement2020-08-12394-4449/+3997
|\ | | | | Update the code to Java 5 features
| * Merge branch 'master' into feature/java5Andy Clement2020-08-121-13/+33
| |\ | |/ |/|
* | Add a debug flag to workaround issue until we can sort it (565713)Andy Clement2020-08-101-15/+35
| |
| * Unnecessary unboxingLars Grefer2020-08-0830-58/+58
| | | | | | | | | | | | Reports "unboxing", e.g. explicit unwrapping of wrapped primitive values. Unboxing is unnecessary under Java 5 and newer, and can be safely removed. Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
| * Unnecessary boxingLars Grefer2020-08-0825-57/+58
| | | | | | | | | | | | Reports explicit boxing, i.e. wrapping of primitive values in objects. Explicit manual boxing is unnecessary under Java 5 and newer, and can be safely removed. Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
| * 'String.indexOf()' expression is replaceable with 'contains()'Lars Grefer2020-08-08105-238/+235
| | | | | | | | | | | | Reports any String.indexOf() expressions which can be replaced with a call to the String.contains() method available in Java 5 and newer. Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
| * 'while' loop replaceable with enhanced 'for' loopLars Grefer2020-08-0812-68/+44
| | | | | | | | | | | | Reports while loops which iterate over collections, and can be replaced with an enhanced for loop (i.e. foreach iteration syntax). Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
| * 'for' loop replaceable with enhanced 'for' loopLars Grefer2020-08-08336-4045/+3619
|/ | | | | | Reports for loops which iterate over collections or arrays, and can be replaced with an enhanced for loop (i.e. the foreach iteration syntax). Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
* PolishAndy Clement2020-07-227-445/+467
|
* Fix serialVersionUID initialization for java9+eli-fin2020-07-221-24/+13
| | | | | | Move initialization of static final serialVersionUID field to clinit, since as of java9+, the runtime won't allow setting final fields outside clinit Signed-off-by: Eli Finkel <eyfinkel@gmail.com>
* Rev to 1.9.7.BUILD-SNAPSHOTAndy Clement2020-07-2229-31/+31
|
* Fixed a misplaced <para> element in the Docbook documentation for ajcEmmanuel Bourg2020-07-221-1/+1
|
* AspectJ 1.9.6 final bitsV1_9_6Andy Clement2020-07-2235-39/+73
|
generated by cgit v1.2.3 (git 2.39.1) at 2025-01-07 05:34:58 +0000