aboutsummaryrefslogtreecommitdiffstats
path: root/lib
Commit message (Collapse)AuthorAgeFilesLines
* Create javadoc for all public artifacts, fix dependenciesAlexander Kriegisch2021-05-161-1/+0
| | | | | | | | | | | | | | | | | | | | | | Sonatype OSSRH repository rules require source and javadoc JARs in order to create staging repositories for releases to be promoted to Maven Central. So I added build steps to unzip the source JARs and then create Javadocs for them. FIXME: This configuration works with JDK 16, but throws errors on other JDK versions, e.g. 14. It looks as if the Maven Javadoc plugin does not do a particularly good job applying the plugin settings in a way making it work with different JDK javadoc tool versions. I am saying that, because when using the tool directly on the console, it works with basic settings and the correct classpath. In order to enable creating uber JARs via Maven Shade in the future, I also added missing dependencies. Maven Assembly descriptors just assume that all the necessary class files and sources already exist where it copies them from. But several of the dependency modules were not explicitly listed as such by the uber JAR modules. I fixed that. Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
* Remove jdiffAndy Clement2021-05-142-87/+0
|
* Move Enforcer Plugin to 'compile' phase in 'lib'Alexander Kriegisch2021-05-071-1/+1
| | | | | | | | | | | | | | | | | | There is a strange effect in Maven builds: Depending on which profiles are active when building the project - even seemingly unrelated ones like 'create-docs' or 'clean-libs' - the execution order of plugins in the 'process-resources' phase can vary. Specifically, Build Helper vs. Enforcer in module 'lib', which both were in the same phase, can sometimes be executed in lexical order, which I expected, or the other way around, which makes the build fail if the existence of the marker file is checked by Enforcer before Build Helper even had a chance to create it. Probably, this is because Build Helper is defined inside a profile and Enforcer outside of any. Therefore, the safest way to ensure correct ordering of the two is to place Enforcer in a later phase, in this case 'compile'. Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
* Improve 'name' tags in POMsAlexander Kriegisch2021-05-061-1/+0
| | | | | | | | | | | | | | I tripped over not finding aspectjtools in my IntelliJ Maven view many times, because it was listed as "AspectJ Compiler". So I renamed it to "AspectJ Tools (Compiler)". Now it resembles more the artifact ID and still retains the information that it is the artifact containing AJC. For the 'lib' module I removed the 'name' tag again, because it is not one of the main artifacts we publish. Now the POMs are more like Andy might have intended them to be, using a human-readable 'name' only for the main artifacts. Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
* Bump download-maven-plugin 1.6.1 -> 1.6.3Alexander Kriegisch2021-05-051-1/+1
| | | | | | | | | | | | | | | | | | | In the previous GitHub build, there were warnings in the log because of failed downloads. Actually, the default is to fail the build, but that did not happen. Let us try a more recent version, maybe it fixes an old bug, even though in the diff between the versions I did not see anything obvious here. Anyway, I created an issue ticket: https://github.com/maven-download-plugin/maven-download-plugin/issues/185 BTW, our build only failed later during the Maven Enforcer sanity check, because several files from the check list were missing after a seemingly successful provisioning. Actually, I am glad I added this "redundant" double-checking step to the build, otherwise the build would not have failed in the 'lib' module but much later in a hard to detect spot. Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
* Provision libraries in 'lib' automaticallyAlexander Kriegisch2021-05-051-587/+680
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Upon special request by Andy Clement, I included 'lib' as a child module in the parent POM again, making several modules which refer to downloaded library files dependent the 'lib' module. I am not sure I caught all of them, but I hope so. Now after cloning the project and configuring the token for reading from GitHub Packages (sorry!), you can just run a Maven build for the main project and no longer need to fail the first build, read the Maven Enforcer message and run 'cd lib && mvn compile' as a first step. This convenience comes at the price of a more complex POM and two new profiles: - Profile 'provision-libs' is auto-activated by the absence of a marker file, kicking off the library provisioning process and creating same marker file at the end, if successful. Therefore, during subsequent builds libraries will not be re-provisioned, because the marker file exists and Maven skips all download and (un)zip steps, which saves build time and bandwidth. Otherwise offline builds would not work either. - Profile 'clean-libs' needs to be activated manually, because by default 'mvn clean' will not erase provisioned libraries. In most cases, even after a clean a developer does not want to re-provision all libraries if they have not changed (e.g. new JDT Core build). But if you do wish too erase the libraries and the marker file, just call 'cd lib && mvn -P clean-libs clean'. Please note: The Maven Enforcer build step, which additionally checks for existence of other files, still exists and was moved from the parent POM to 'libs'. No matter if provisioning was just done or skipped because the main marker file exists, a quick heuristic check for that list of files is done during each build, failing the build with a comprehensive message if an inconsistency was found. The error message says which files are missing and tells the user: "There is an inconsistency in module subdirectory 'lib'. Please run 'mvn --projects lib -P clean-libs clean compile'. This should take care of cleaning and freshly downloading all necessary libraries to that directory, where some tests expect them to be." This should cover the topic. Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
* Remove managing obsolete folder lib/asmAlexander Kriegisch2021-04-161-26/+0
| | | | | | | | The new string AjcTestCase.CLASSPATH_ASM_RENAMED dynamically determines the 'asm-renamed' location from the classpath, system property 'java.class.path'. Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
* Add lib/docbook to Maven CleanAlexander Kriegisch2021-04-131-0/+1
| | | | Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
* Delete all remaining docbook contents, download them insteadAlexander Kriegisch2021-04-107-51/+22
| | | | | | | | Actually, only fop:fop:0.20.5 and batik:batik-1.5-fop:0.20-5 are really used in addition to lib/saxon/saxon.jar (saxon:saxon:6.5.3). So the rest does not need to be replaced and can just be wiped. Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
* Delete docbook XSL + DTD directories from libs, download insteadAlexander Kriegisch2021-04-10384-91699/+58
| | | | | | | | It was kind of difficult to identify and find the vintage versions used in AspectJ in download archives, but finally I managed to. Docs generation looks good visually, tests to be run on GitHub CI. Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
* Completely delete Jython in lib/jythonAlexander Kriegisch2021-04-10331-73434/+0
| | | | | | | | | AFAIK, Jython is not used anywhere in out tests, also not in combination with Ant. So I have decided to delete it altogether. If the build passes, we should be fine and be able to travel more lightly in the future. Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
* Switch from 'libx' to 'lib', delete all obsolete binariesAlexander Kriegisch2021-04-1085-11077/+643
| | | | | | | | | | | | | | | | | | | | Because 'cd lib && mvn compile' can now download and (un)zip many previously SCM-committed third-party dependencies, the following 'lib' subdirectories have been deleted: - ant - asm - commons - jarjar - junit - regexp - saxon This one is new (but not stored in SCM): - jdtcore-aj For each of them, there now is a .gitignore entry, so as to prevent developers from accidentally committing the downloaded binaries again. Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
* Remove JRockit LTW support, particularly JRockitAgentAlexander Kriegisch2021-04-104-8/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | In two places, the documentation now contains this text: "Since AspectJ 1.9.7, the obsolete Oracle/BEA JRockit agent is no longer part of AspectJ. JRockit JDK never supported Java versions higher than 1.6. Several JRockit JVM features are now part of HotSpot and tools like Mission Control available for OpenJDK and Oracle JDK." The decision to drop JRockit support was made during a discussion between Alexander Kriegisch and Andy Clement: Andy Clement wrote on 26 Mar 2021: > Yes I think so. > > > Alexander Kriegisch wrote on 26 Mar 2021: > >> https://en.wikipedia.org/wiki/JRockit >> >> Can we get rid of that? AspectJ requires Java 8, JRockit never >> supported more than Java 6. Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
* Move lib/ext/jrockit to just lib/jrockitAlexander Kriegisch2021-04-104-0/+0
| | | | | | | | It was the only subdirectory under lib/ext anyway and somehow always irritating and difficult to find when just using a directory browser in the IDE. Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
* Replace JDiff by regular Maven dependency from GitHub PackagesAlexander Kriegisch2021-04-102-2/+0
| | | | | | One less SCM-committed binary, one less system-scoped dependency. Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
* Remove ASM 2.0 dependency from AtAjLTWTests::testLTWUnweavableAlexander Kriegisch2021-03-291-0/+0
| | | | | | | | | | | | | | | | | | | | The test class UnweavableTest used ASM 2.0 API. I upgraded in two ways: 1. Now the ASM 9.1 API is used. Probably works with much older versions too (just not as old as 2.0), as long as the method and constructor signatures are the same). 2. The class now uses the AspectJ version of ASM (i.e. package names aj.org.objectweb.asm.*) and therefore can just use ASM as it is on the classpath for module 'tests' already. There is no more need to manually add '<pathelement path="${aj.root}/lib/asm/asm-2.0.jar"/>' to the Ant build script for that test. Consequently, asm-2.0.jar can be eliminated from Git SCM completely, because it was only used in this one test. BTW, I also removed some deprecated API and other types of warnings in UnweavableTest. Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
* Remove JDiff sources + binaries accidentally committed in @c89830feAlexander Kriegisch2021-03-2911-1095/+0
| | | | | | | The deleted files are just the unpacked + content of lib/jdiff/jdiff.jar. Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
* Upgrade to ASM 9.1, delete obsolete ASM binariesAlexander Kriegisch2021-03-167-10/+9
| | | | | | | | | | | Keep only ASM 2.0 binary because it is still used in UnweavableTest which uses an old ASM API, e.g. with a ClassWriter constructor which no longer exists. Also add JarJar 1.3 library because it is needed by an Ant task in lib/asm/build.xml. Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
* Update ASM and fix packaging for matcher artifactAndy Clement2020-07-179-2/+2
|
* Update to an ASM for Java13Andy Clement2019-11-255-2/+2
|
* fixing test failures running under eclipseAndy Clement2019-02-111-0/+0
|
* tidyupAndy Clement2019-02-0812-0/+1097
|
* better handling for 1.8 modulesAndy Clement2018-10-151-0/+0
|
* More fixes for 1.9.2V1_9_2_RC2Andy Clement2018-10-018-2/+2
| | | | | | - update to more recent JDT to pickup Nestmates fix - bcel updated for NestMembers/NestHost attributes - testcases for nestmates
* 1.9.2.RC1 changesV1_9_2_RC1Andy Clement2018-09-299-3/+3
|
* Rebuilt as a DEVELOPMENT versionAndy Clement2018-05-251-0/+0
|
* Support Java10Andy Clement2018-04-188-2/+2
|
* Bug#531694: generate more optional thisJoinPoint construction codeAndy Clement2018-03-095-0/+0
| | | | | | | This commit introduces some new methods into the runtime Factory class and modifies code generation to use them (and to use the form of the LDC bytecode that loads class constants).
* Fix for Bug 531819 - Negative parameter annotation matching not behavingAndy Clement2018-02-283-0/+0
|
* Add missing cases to bcel constantToStringAndy Clement2018-02-0712-3/+2
|
* rebuilt internal dependenciesAndy Clement2017-10-206-1/+1
|
* Latest build of bcelAndy Clement2017-09-283-0/+0
|
* Rebuilt bcel with latest changesAndy Clement2017-09-272-0/+0
|
* Various changes to get tests passing on 1.8 and 1.9Andy Clement2017-09-243-0/+0
|
* various changes to make more tests pass on Java9Andy Clement2017-09-223-0/+0
|
* Upgraded to ASM 6 BETAAndy Clement2017-09-213-2/+2
|
* rebuilt bcelAndy Clement2017-09-214-0/+0
|
* Bring Java9 branch in line with 1.8.11 progressAndy Clement2017-09-218-0/+0
|\
| * reduced min Java version to 1.6Andy Clement2016-12-161-0/+0
| |
| * fix warnings in build - support .isJava8 option in buildV1_8_10Andy Clement2016-12-091-0/+0
| |
| * Polishing for 1.8.10 releaseAndy Clement2016-12-081-0/+0
| | | | | | | | | | - reduced build level from 8 to 7 so that the weaver can be used on Java7. - minor readme tweaks
| * Fix 500035: handling target only binding in @AJ pointcutAndy Clement2016-11-182-0/+0
| |
| * Fix 500796: Allow for kotlin creating 'synthetic' local variable table entriesAndy Clement2016-11-074-0/+0
| |
| * Upgraded to new JDT compiler - neon.1 and a bitAndy Clement2016-11-072-0/+0
| |
* | rebuilt bcelAndy Clement2017-09-214-0/+0
| |
* | Merged post 1.8.5 changes into Java9 branchAndy Clement2017-09-205-3/+3
|\|
| * Fix 487927: ClassFormatException if LocalVariableTable data cannot be fully readAndy Clement2016-02-182-0/+0
| |
| * Fix 487694: Race condition in annotation unpacking can surface through ↵Andy Clement2016-02-113-0/+0
| | | | | | | | Spring AOP
| * Fix 485055: declare @field failing for final String fields (see also Bug 327141)Andy Clement2016-01-053-0/+0
| |
| * Update Asm to pick up fixes for stack map generationAndy Clement2015-08-105-3/+3
| | | | | | | | Issue: https://bugs.eclipse.org/bugs/show_bug.cgi?id=452056