aboutsummaryrefslogtreecommitdiffstats
path: root/org.aspectj.ajdt.core
Commit message (Collapse)AuthorAgeFilesLines
...
* Improve batch compiler usage messagesAlexander Kriegisch2021-03-201-33/+40
| | | | | | | | | | | - Use spaces instead of tabs for indentation. - Document parameters bound in Eclipse JDT, e.g. {0} is not the compiler name there but the system's path separator ';' or ':'. So if we want to display the compiler name, we need {1}. - For both normal usage and '-X' usage, compiler name + version are printed now. Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
* Strip down compiler messages to AspectJ-specific onesAlexander Kriegisch2021-03-192-276/+26
| | | | | | | | | | | | | | | | | | | | Delete all properties from messages_aspectj.properties which were just copied from Eclipse and basically the same. This not only gets rid of duplicates but also eliminates differences found between upstream and AspectJ strings which were just cause by errors or oversights during manual upgrade. TODO: - Find a way to print the '-X' options as info instead of yielding 'abort', making it seem as if compilation failed and print the usage message to stdErr instead of stdOut. - Eclipse also has misc.usage.warn, not just misc.usage, i.e. usage info specifically for warning options. Make sure that AspectJ uses it consistently. - Find a way to merge AspectJ-specific options into the standard Eclipse usage text instead of completely replacing it, further reducing the need to merge and copy upstream content. Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
* Begin migration to 'aspectj' locale for compiler messagesAlexander Kriegisch2021-03-192-12/+1
| | | | | | | | | | | | | | | | | | | Renamed messages.properties to messages_aspectj.properties and moved to a path identical with the Eclipse original resource file. Therefore, it is now just treated as a localised version of it. The new jdtcore-for-aspectj.jar already contains logic to use the new locale. Hence, BuildArgParser no longer needs the static block to initialise its own resource bundle, Eclipse JDT will automatically pick it up. The version string was also updated to the new Eclipse merge commit hash + date + "Java16". TODO: Strip down properties file in order to only contain delta to Eclipse. Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
* Add Java 15 class vile version to BCEL constants, adjust test tools etc.Alexander Kriegisch2021-03-161-39/+47
| | | | Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
* Upgrade to ASM 9.1, delete obsolete ASM binariesAlexander Kriegisch2021-03-161-1/+1
| | | | | | | | | | | Keep only ASM 2.0 binary because it is still used in UnweavableTest which uses an old ASM API, e.g. with a ClassWriter constructor which no longer exists. Also add JarJar 1.3 library because it is needed by an Ant task in lib/asm/build.xml. Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
* Upgrade JDT Core to @3caefb80 (4.20 snapshot, date 2021-03-09)Alexander Kriegisch2021-03-161-2/+16
| | | | | | | Add methods isRecord() and getRecordComponents() to class CompactTypeStructureRepresentation Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
* Fix 'ajdoc' tests for Java 15 buildAlexander Kriegisch2021-03-143-26/+26
| | | | Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
* AjcTestCase cosmetics: surround command in failure report by quotesAlexander Kriegisch2021-03-111-2/+2
| | | | | | This is the same for successful tests in class CompilationResult. Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
* AjBuildManager: use try with resources in 2 placesAlexander Kriegisch2021-03-111-7/+1
| | | | | | | | I was debugging something in ModuleTests, trying to find out if there are resource leaks. They were not in this class but in FileUtil - see next commit. However, the little refactoring here does not hurt either. Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
* Typo fixesJerry James2020-09-141-1/+1
|
* Fix javadoc references to nonexistent fields, classes, or packagesJerry James2020-09-144-6/+5
|
* Fix misplaced or incorrect javadoc tagsJerry James2020-09-143-8/+7
|
* Fix misplaced or incorrectly nested HTML tagsJerry James2020-09-142-4/+6
|
* Fix incorrect HTML entities in javadoc commentsJerry James2020-09-148-24/+24
|
* Revert to 1.9.7.BUILD-SNAPSHOTAndy Clement2020-08-211-1/+1
|
* 1.9.7 milestone 1 publishedAndy Clement2020-08-211-1/+1
|
* Remove unnecessary interface modifiersLars Grefer2020-08-173-39/+39
| | | | Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
* Merge pull request #10 from larsgrefer/cleanup/pomAndy Clement2020-08-161-1/+0
|\ | | | | Cleanup the Maven pom.xml files
| * Remove project.parent.relative path as ../pom.xml is already the defaultLars Grefer2020-08-151-1/+0
| | | | | | | | Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
* | Merge branch 'master' into feature/collection-performanceAndy Clement2020-08-1525-29/+0
|\ \
| * | Cleanup unused importsLars Grefer2020-08-1625-30/+2
| |/ | | | | | | Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
* | Weaken Collection declarationsLars Grefer2020-08-158-12/+14
| | | | | | | | | | | | Reports on declarations of Collection variables made by using the collection class as the type, rather than an appropriate interface. Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
* | Redundant Collection.addAll() callLars Grefer2020-08-154-8/+4
| | | | | | | | | | | | Reports Collection.addAll() and Map.putAll() calls after instantiation of a collection using a constructor call without arguments. Such constructs can be replaced with a single call to a parametrized constructor which simplifies code. Also for some collections the replacement might be more performant. Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
* | Collection.toArray() call styleLars Grefer2020-08-157-13/+14
| | | | | | | | | | | | | | There are two styles to convert a collection to an array: either using a pre-sized array (like c.toArray(new String[c.size()])) or using an empty array (like c.toArray(new String[0]). In older Java versions using pre-sized array was recommended, as the reflection call which is necessary to create an array of proper size was quite slow. However since late updates of OpenJDK 6 this call was intrinsified, making the performance of the empty array version the same and sometimes even better, compared to the pre-sized version. Also passing pre-sized array is dangerous for a concurrent or synchronized collection as a data race is possible between the size and toArray call which may result in extra nulls at the end of the array, if the collection was concurrently shrunk during the operation. Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
* | Single Map method can be usedLars Grefer2020-08-152-20/+4
| | | | | | | | | | | | Reports common usage patterns of java.util.Map that could be replaced with Java 8 methods: getOrDefault(), computeIfAbsent(), putIfAbsent(), merge(), or replaceAll(). Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
* | Manual array copyLars Grefer2020-08-151-45/+21
| | | | | | | | | | | | Reports the manual copying of array contents which may be replaced by calls to System.arraycopy(). Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
* | Replace List.indexOf() with List.contains()Lars Grefer2020-08-151-1/+1
| | | | | | | | Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
* | Manual array to collection copyLars Grefer2020-08-154-24/+7
|/ | | | | | Reports the copying of array contents to a collection where each element is added individually using a for loop. Such constructs may be replaced by a call to Collection.addAll(Arrays.asList()) or Collections.addAll(). Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
* Fix up tests and reduce verbosity on J11Andy Clement2020-08-142-2/+2
|
* Trying to reduce test verbosityAndy Clement2020-08-133-102/+115
|
* Use the diamond operator where possibleLars Grefer2020-08-1334-159/+159
| | | | Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
* Unnecessary unboxingLars Grefer2020-08-083-4/+4
| | | | | | Reports "unboxing", e.g. explicit unwrapping of wrapped primitive values. Unboxing is unnecessary under Java 5 and newer, and can be safely removed. Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
* Unnecessary boxingLars Grefer2020-08-085-8/+8
| | | | | | Reports explicit boxing, i.e. wrapping of primitive values in objects. Explicit manual boxing is unnecessary under Java 5 and newer, and can be safely removed. Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
* 'String.indexOf()' expression is replaceable with 'contains()'Lars Grefer2020-08-0814-38/+36
| | | | | | Reports any String.indexOf() expressions which can be replaced with a call to the String.contains() method available in Java 5 and newer. Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
* 'while' loop replaceable with enhanced 'for' loopLars Grefer2020-08-081-23/+19
| | | | | | Reports while loops which iterate over collections, and can be replaced with an enhanced for loop (i.e. foreach iteration syntax). Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
* 'for' loop replaceable with enhanced 'for' loopLars Grefer2020-08-0859-855/+769
| | | | | | Reports for loops which iterate over collections or arrays, and can be replaced with an enhanced for loop (i.e. the foreach iteration syntax). Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
* PolishAndy Clement2020-07-222-26/+25
|
* Rev to 1.9.7.BUILD-SNAPSHOTAndy Clement2020-07-221-1/+1
|
* AspectJ 1.9.6 final bitsV1_9_6Andy Clement2020-07-221-1/+1
|
* Update ASM and fix packaging for matcher artifactAndy Clement2020-07-171-142/+142
|
* Fix for 558995: NullPointerException at ↵Andy Clement2020-04-221-2/+8
| | | | org.aspectj.weaver.ReferenceType.getWeaverState
* fix tests running on windowseli-fin2020-04-211-1/+1
| | | | | This caused checkRtJar to return an error, which led to some tests to fail Signed-off-by: Eli Finkel <eyfinkel@gmail.com>
* Fix support for -14 on command line - was missing from JDTAndy Clement2020-04-211-7/+10
|
* Include JDTCore for Java14Andy Clement2020-04-202-16/+16
|
* Move to 1.9.6.BUILD-SNAPSHOT versionAndy Clement2019-11-281-1/+1
|
* 1.9.5 release versions in pomsV1_9_5Andy Clement2019-11-281-1/+1
|
* Java 13 supportAndy Clement2019-11-2512-281/+303
|
* Fix Bug 551084 - NullPointerException at ↵Andy Clement2019-09-161-17/+17
| | | | org.aspectj.ajdt.internal.core.builder.AjBuildManager.checkRtJar
* make test a bit more reliableAndy Clement2019-09-091-53/+42
|
* Fix Bug 550290 - Lack of TypeSafeEnum#hashCode may lead to non-deterministic ↵Andy Clement2019-09-091-10/+11
| | | | bytecode