aboutsummaryrefslogtreecommitdiffstats
path: root/org.aspectj.matcher/src/main
Commit message (Collapse)AuthorAgeFilesLines
* Remove unnecessary interface modifiersLars Grefer2020-08-1722-388/+388
| | | | Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
* Merge branch 'master' into feature/collection-performanceAndy Clement2020-08-1513-15/+0
|\
| * Cleanup unused importsLars Grefer2020-08-1613-15/+0
| | | | | | | | Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
* | Weaken Collection declarationsLars Grefer2020-08-152-4/+4
| | | | | | | | | | | | Reports on declarations of Collection variables made by using the collection class as the type, rather than an appropriate interface. Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
* | Redundant Collection.addAll() callLars Grefer2020-08-151-2/+1
| | | | | | | | | | | | Reports Collection.addAll() and Map.putAll() calls after instantiation of a collection using a constructor call without arguments. Such constructs can be replaced with a single call to a parametrized constructor which simplifies code. Also for some collections the replacement might be more performant. Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
* | Collection.toArray() call styleLars Grefer2020-08-157-10/+10
| | | | | | | | | | | | | | There are two styles to convert a collection to an array: either using a pre-sized array (like c.toArray(new String[c.size()])) or using an empty array (like c.toArray(new String[0]). In older Java versions using pre-sized array was recommended, as the reflection call which is necessary to create an array of proper size was quite slow. However since late updates of OpenJDK 6 this call was intrinsified, making the performance of the empty array version the same and sometimes even better, compared to the pre-sized version. Also passing pre-sized array is dangerous for a concurrent or synchronized collection as a data race is possible between the size and toArray call which may result in extra nulls at the end of the array, if the collection was concurrently shrunk during the operation. Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
* | Manual array copyLars Grefer2020-08-153-9/+3
| | | | | | | | | | | | Reports the manual copying of array contents which may be replaced by calls to System.arraycopy(). Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
* | Manual array to collection copyLars Grefer2020-08-151-6/+3
|/ | | | | | Reports the copying of array contents to a collection where each element is added individually using a for loop. Such constructs may be replaced by a call to Collection.addAll(Arrays.asList()) or Collections.addAll(). Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
* Remove checks for old Java VersionsLars Grefer2020-08-133-46/+35
| | | | Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
* Use the diamond operator where possibleLars Grefer2020-08-1347-191/+191
| | | | Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
* Merge branch 'master' into feature/java5Andy Clement2020-08-121-13/+33
|\
| * Add a debug flag to workaround issue until we can sort it (565713)Andy Clement2020-08-101-15/+35
| |
* | Unnecessary unboxingLars Grefer2020-08-085-13/+13
| | | | | | | | | | | | Reports "unboxing", e.g. explicit unwrapping of wrapped primitive values. Unboxing is unnecessary under Java 5 and newer, and can be safely removed. Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
* | Unnecessary boxingLars Grefer2020-08-085-9/+10
| | | | | | | | | | | | Reports explicit boxing, i.e. wrapping of primitive values in objects. Explicit manual boxing is unnecessary under Java 5 and newer, and can be safely removed. Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
* | 'String.indexOf()' expression is replaceable with 'contains()'Lars Grefer2020-08-089-13/+13
| | | | | | | | | | | | Reports any String.indexOf() expressions which can be replaced with a call to the String.contains() method available in Java 5 and newer. Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
* | 'while' loop replaceable with enhanced 'for' loopLars Grefer2020-08-081-3/+2
| | | | | | | | | | | | Reports while loops which iterate over collections, and can be replaced with an enhanced for loop (i.e. foreach iteration syntax). Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
* | 'for' loop replaceable with enhanced 'for' loopLars Grefer2020-08-0842-355/+314
|/ | | | | | Reports for loops which iterate over collections or arrays, and can be replaced with an enhanced for loop (i.e. the foreach iteration syntax). Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
* PolishAndy Clement2020-07-223-59/+73
|
* Fix 550705: tricky intermittent verify errorAndy Clement2020-04-291-11/+24
|
* polishAndy Clement2019-11-281-31/+28
|
* Debug for 551732Andy Clement2019-11-281-9/+14
|
* Fix 550494Andy Clement2019-11-271-8/+11
|
* Fix Bug 550290 - Lack of TypeSafeEnum#hashCode may lead to non-deterministic ↵Andy Clement2019-09-092-27/+43
| | | | bytecode
* polish for 1.9.3V1_9_3Andy Clement2019-04-041-4/+5
|
* 333274: more tests and fixes: nested @Around advice with proceedAndy Clement2019-02-193-1/+28
|
* Adding ProceedingJoinPoint built in typeAndy Clement2019-02-191-1/+1
|
* Fix version tagging for info stringsAndy Clement2019-02-111-1/+1
|
* tweak matcher for weaver module requirementsAndy Clement2019-01-253-1/+2
|
* mavenized org.aspectj.matcher module - wipAndy Clement2019-01-23258-0/+52802