aboutsummaryrefslogtreecommitdiffstats
path: root/weaver/src
Commit message (Collapse)AuthorAgeFilesLines
* Make sure to clean up temp-dirs in 'weaver' moduleAlexander Kriegisch2021-04-091-2/+5
| | | | | | | | | Maven Clean now deletes '' directories if it finds any. Furthermore, AsynchronousFileCacheBackingTestSupport now not just deletes directory contents but also removes the empty corresponding directories afterwards. Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
* Fix some deprecated Java and JUnit warnings by using newer API callsAlexander Kriegisch2021-03-214-7/+6
| | | | Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
* Add Java 15 class vile version to BCEL constants, adjust test tools etc.Alexander Kriegisch2021-03-161-7/+7
| | | | Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
* Upgrade to ASM 9.1, delete obsolete ASM binariesAlexander Kriegisch2021-03-161-2/+2
| | | | | | | | | | | Keep only ASM 2.0 binary because it is still used in UnweavableTest which uses an old ASM API, e.g. with a ClassWriter constructor which no longer exists. Also add JarJar 1.3 library because it is needed by an Ant task in lib/asm/build.xml. Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
* Fix 'ajdoc' tests for Java 15 buildAlexander Kriegisch2021-03-144-31/+31
| | | | Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
* Make MoveInstructionsWeaveTestCase.testFancyHello pass when run twiceAlexander Kriegisch2021-03-131-9/+14
| | | | | | | | | | | Reset counter, just in case this test runs multiple times in one JVM. This can happen e.g. due to "run all tests" in IntelliJ IDEA, which directly runs this test class and als WeaverModuleTests, both of which implement junit.framework.TestCase. In that case, during the second run the counter would start at a higher base count, making the 2nd test run fail. Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
* Remove call to System.outAnuj Dodhia2020-12-021-2/+1
|
* Typo fixesJerry James2020-09-142-3/+3
|
* Fix javadoc references to nonexistent fields, classes, or packagesJerry James2020-09-141-3/+3
|
* Fix misplaced or incorrect javadoc tagsJerry James2020-09-146-6/+5
|
* Fix misplaced or incorrectly nested HTML tagsJerry James2020-09-1411-33/+49
|
* Fix incorrect HTML entities in javadoc commentsJerry James2020-09-144-4/+4
|
* Remove unnecessary interface modifiersLars Grefer2020-08-174-69/+69
| | | | Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
* Remove unnecessary enum modifiersLars Grefer2020-08-172-2/+2
| | | | Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
* polishAndy Clement2020-08-163-38/+38
|
* Merge branch 'master' into feature/collection-performanceAndy Clement2020-08-1517-22/+0
|\
| * Cleanup unused importsLars Grefer2020-08-1617-22/+0
| | | | | | | | Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
* | Weaken Collection declarationsLars Grefer2020-08-155-24/+24
| | | | | | | | | | | | Reports on declarations of Collection variables made by using the collection class as the type, rather than an appropriate interface. Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
* | Redundant Collection.addAll() callLars Grefer2020-08-154-14/+7
| | | | | | | | | | | | Reports Collection.addAll() and Map.putAll() calls after instantiation of a collection using a constructor call without arguments. Such constructs can be replaced with a single call to a parametrized constructor which simplifies code. Also for some collections the replacement might be more performant. Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
* | Collection.toArray() call styleLars Grefer2020-08-154-4/+4
| | | | | | | | | | | | | | There are two styles to convert a collection to an array: either using a pre-sized array (like c.toArray(new String[c.size()])) or using an empty array (like c.toArray(new String[0]). In older Java versions using pre-sized array was recommended, as the reflection call which is necessary to create an array of proper size was quite slow. However since late updates of OpenJDK 6 this call was intrinsified, making the performance of the empty array version the same and sometimes even better, compared to the pre-sized version. Also passing pre-sized array is dangerous for a concurrent or synchronized collection as a data race is possible between the size and toArray call which may result in extra nulls at the end of the array, if the collection was concurrently shrunk during the operation. Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
* | Single Map method can be usedLars Grefer2020-08-151-5/+1
| | | | | | | | | | | | Reports common usage patterns of java.util.Map that could be replaced with Java 8 methods: getOrDefault(), computeIfAbsent(), putIfAbsent(), merge(), or replaceAll(). Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
* | Collections.sort() can be replaced with List.sort()Lars Grefer2020-08-154-4/+4
| | | | | | | | | | | | Reports calls to Collections.sort(list, comparator) which could be replaced with list.sort(comparator). Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
* | Manual array to collection copyLars Grefer2020-08-151-6/+2
|/ | | | | | Reports the copying of array contents to a collection where each element is added individually using a for loop. Such constructs may be replaced by a call to Collection.addAll(Arrays.asList()) or Collections.addAll(). Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
* Fix the serial version UID contribution to work properlyAndy Clement2020-08-141-126/+126
|
* Merge branch 'master' of github.com:eclipse/org.aspectj into ↵Lars Grefer2020-08-141-63/+87
|\ | | | | | | remove-old-version-checks
| * Fix up tests and reduce verbosity on J11Andy Clement2020-08-141-63/+87
| |
* | Simplify checks for Java 8 to trueLars Grefer2020-08-141-3/+1
| | | | | | | | Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
* | Remove checks for old Java VersionsLars Grefer2020-08-139-122/+93
|/ | | | Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
* Adjust ASM version number used to work properly with Records (J14)Andy Clement2020-08-131-2/+3
|
* Merge pull request #3 from larsgrefer/feature/github-actionsAndy Clement2020-08-131-6/+8
|\ | | | | Create a simple CI Job using GitHub Actions
| * Fix TestcaseLars Grefer2020-08-131-6/+8
| | | | | | | | Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
* | Use the diamond operator where possibleLars Grefer2020-08-1340-233/+233
|/ | | | Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
* Unnecessary boxingLars Grefer2020-08-085-11/+11
| | | | | | Reports explicit boxing, i.e. wrapping of primitive values in objects. Explicit manual boxing is unnecessary under Java 5 and newer, and can be safely removed. Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
* 'String.indexOf()' expression is replaceable with 'contains()'Lars Grefer2020-08-0810-16/+16
| | | | | | Reports any String.indexOf() expressions which can be replaced with a call to the String.contains() method available in Java 5 and newer. Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
* 'while' loop replaceable with enhanced 'for' loopLars Grefer2020-08-086-21/+9
| | | | | | Reports while loops which iterate over collections, and can be replaced with an enhanced for loop (i.e. foreach iteration syntax). Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
* 'for' loop replaceable with enhanced 'for' loopLars Grefer2020-08-0834-404/+321
| | | | | | Reports for loops which iterate over collections or arrays, and can be replaced with an enhanced for loop (i.e. the foreach iteration syntax). Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
* Fix serialVersionUID initialization for java9+eli-fin2020-07-221-24/+13
| | | | | | Move initialization of static final serialVersionUID field to clinit, since as of java9+, the runtime won't allow setting final fields outside clinit Signed-off-by: Eli Finkel <eyfinkel@gmail.com>
* PolishAndy Clement2020-04-222-16/+15
|
* polishAndy Clement2019-11-2942-89/+139
|
* Fix 550494Andy Clement2019-11-271-55/+45
|
* Java 13 supportAndy Clement2019-11-251-13/+20
|
* Fix Bug 387122 - threadlocal in weavingadaptor is potential memory leakAndy Clement2019-09-121-22/+22
|
* 543657: tweak to use current data rather than last known packed dataAndy Clement2019-09-111-5/+6
|
* Moved tests around for avoiding weaving switch infrastructure methodAndy Clement2019-09-112-58/+57
|
* - dont't weave synthetic enum helper method for switchSemyon Danilov2019-09-102-1/+15
| | | | | | - add test for switch on enum with around all advice Signed-off-by: Semyon Danilov <samvimes@yandex.ru>
* Fix Bug 550696 - ClassCastException during load time weaving: ↵Andy Clement2019-09-091-3/+3
| | | | InstructionHandle cannot be cast to BranchHandle
* Fix 548785: Check level is >=1.8 when looking to skip inlining around advice ↵Andy Clement2019-07-022-14/+15
| | | | lambdas
* Fix 548860: don't pass lowercased string throughAndy Clement2019-07-021-32/+31
|
* Fix 547808: npe regression for multi @AroundAndy Clement2019-06-031-61/+62
|
* Final bits of AspectJ 1.9.4Andy Clement2019-05-103-28/+280
|