From a508fd5315c6330f2057c219aebc35b15d0ea497 Mon Sep 17 00:00:00 2001 From: Lars Grefer Date: Sat, 8 Aug 2020 03:09:01 +0200 Subject: 'while' loop replaceable with enhanced 'for' loop Reports while loops which iterate over collections, and can be replaced with an enhanced for loop (i.e. foreach iteration syntax). Signed-off-by: Lars Grefer --- .../org/aspectj/ajde/internal/LstBuildConfigFileUpdater.java | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) (limited to 'ajde') diff --git a/ajde/src/main/java/org/aspectj/ajde/internal/LstBuildConfigFileUpdater.java b/ajde/src/main/java/org/aspectj/ajde/internal/LstBuildConfigFileUpdater.java index f3e2154cd..4e59e5d74 100644 --- a/ajde/src/main/java/org/aspectj/ajde/internal/LstBuildConfigFileUpdater.java +++ b/ajde/src/main/java/org/aspectj/ajde/internal/LstBuildConfigFileUpdater.java @@ -81,9 +81,8 @@ class LstBuildConfigFileUpdater { } public boolean exists(String entry, String configFile, String rootPath) { - Iterator it = readConfigFile(configFile).iterator(); - while (it.hasNext()) { - if ((entry).equals(rootPath + "/" + (String) it.next())) { + for (String s : readConfigFile(configFile)) { + if ((entry).equals(rootPath + "/" + s)) { return true; } } @@ -188,9 +187,8 @@ class LstBuildConfigFileUpdater { public void writeConfigFile(String filePath, List fileContents) { Set contentsSet = new TreeSet<>(fileContents); StringBuffer fileContentsSB = new StringBuffer(); - Iterator it = contentsSet.iterator(); - while (it.hasNext()) { - fileContentsSB.append(it.next().toString()); + for (String s : contentsSet) { + fileContentsSB.append(s.toString()); fileContentsSB.append("\n"); } writeFile(fileContentsSB.toString(), filePath); -- cgit v1.2.3