From 3dc53e0351a37fc6d3f6a6e311df0320987edc48 Mon Sep 17 00:00:00 2001 From: Alexander Kriegisch Date: Thu, 31 Mar 2022 12:50:14 +0700 Subject: POM bug: separate jvm.arg.allowSecurityManager from jvm.arg.addOpens Before, this was in a single variable, and for JDK 18+, the security manager setting also falsely overwrote the '--add-opens' command. This was the root cause for a few dozen LTW tests to fail on JDK 18, if they were not run in full LTW mode, i.e. in a separate JVM. After this fix, it should be possible to revert the corresponding commits, at least their non-cosmetic parts. Signed-off-by: Alexander Kriegisch --- docs/developer/BUILD.md | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) (limited to 'docs') diff --git a/docs/developer/BUILD.md b/docs/developer/BUILD.md index d19c4013d..2cc8bfff5 100644 --- a/docs/developer/BUILD.md +++ b/docs/developer/BUILD.md @@ -110,12 +110,16 @@ Other existing profiles, which developers are less likely to actively use becaus profile is inactive by default, because in the context of a Maven build it would cause all tests to be run twice (during module build and again when running the big suite), hence the profile name. - * `jdk-8-to-15` - Activated automatically on JDKs 8-15, setting property `jvm.arg.addOpens` to an empty value, because - it is only needed on JDK 16+, see next bullet point. + * `jdk-8-to-15` - Activated automatically on JDKs 8-15, setting properties `jvm.arg.addOpens` and + `jvm.arg.allowSecurityManager` to empty values, because they are only needed on JDK 16+ or 18+, respectively. See + next bullet point. * `jdk-16-to-xx` - Activated automatically on JDKs 16+, setting property `jvm.arg.addOpens` to value `--add-opens java.base/java.lang=ALL-UNNAMED`, which is needed in order to run LTW tests. + * `jdk-18-to-xx` - Activated automatically on JDKs 18+, setting property `jvm.arg.allowSecurityManager` to value + `-Djava.security.manager=allow`, which is needed by some tests in order to override `System.exit`. + ### Build properties The following properties and their default values in different profile are used in order to activate or skip Maven -- cgit v1.2.3