From 639f5030e0391e831138f9786cf831c3374449e7 Mon Sep 17 00:00:00 2001
From: Lars Grefer <eclipse@larsgrefer.de>
Date: Sat, 15 Aug 2020 17:01:46 +0200
Subject: Weaken Collection declarations

Reports on declarations of Collection variables made by using the collection class as the type, rather than an appropriate interface.

Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
---
 testing-client/src/main/java/org/aspectj/testing/Tester.java     | 2 +-
 testing-client/src/test/java/org/aspectj/testing/TesterTest.java | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

(limited to 'testing-client')

diff --git a/testing-client/src/main/java/org/aspectj/testing/Tester.java b/testing-client/src/main/java/org/aspectj/testing/Tester.java
index d42bcd994..8e6e98db4 100644
--- a/testing-client/src/main/java/org/aspectj/testing/Tester.java
+++ b/testing-client/src/main/java/org/aspectj/testing/Tester.java
@@ -720,7 +720,7 @@ public class Tester {
     private static String[] diffIgnoreDups(Collection<String> set, String[] expected, String msg,
         boolean ignoreDups) {
         ArrayList<String> result = new ArrayList<>();
-        ArrayList<String> actual = new ArrayList<>(set);
+        List<String> actual = new ArrayList<>(set);
         BitSet hits = new BitSet();
         for (int i = 0; i < expected.length; i++) {
             if (!actual.remove(expected[i])) {
diff --git a/testing-client/src/test/java/org/aspectj/testing/TesterTest.java b/testing-client/src/test/java/org/aspectj/testing/TesterTest.java
index 5533739a3..e757dfc4b 100644
--- a/testing-client/src/test/java/org/aspectj/testing/TesterTest.java
+++ b/testing-client/src/test/java/org/aspectj/testing/TesterTest.java
@@ -166,8 +166,8 @@ public class TesterTest extends TestCase {
      * @author isberg
      */
     public static class MyTestReporter implements IMessageHandler {
-        public ArrayList<IMessage> failures = new ArrayList<>();
-        public ArrayList<IMessage> passes = new ArrayList<>();
+        public List<IMessage> failures = new ArrayList<>();
+        public List<IMessage> passes = new ArrayList<>();
 
         public void clear() {
             failures.clear();
-- 
cgit v1.2.3