diff --git a/src/share/vm/classfile/classFileParser.cpp b/src/share/vm/classfile/classFileParser.cpp index fa7986b..0910a7d 100644 --- a/src/share/vm/classfile/classFileParser.cpp +++ b/src/share/vm/classfile/classFileParser.cpp @@ -4264,6 +4264,30 @@ } } + if (this_klass->external_name() != NULL && HotswapDeoptClassPath != NULL) { + const char* deopt_path = HotswapDeoptClassPath; + const char* const end = deopt_path + strlen(deopt_path); + bool deopt_found = false; + while (!deopt_found && deopt_path < end) { + const char* tmp_end = strchr(deopt_path, ','); + if (tmp_end == NULL) { + tmp_end = end; + } + char* deopt_segm_path = NEW_C_HEAP_ARRAY(char, tmp_end - deopt_path + 1, mtInternal); + memcpy(deopt_segm_path, deopt_path, tmp_end - deopt_path); + deopt_segm_path[tmp_end - deopt_path] = '\0'; + if (strstr(this_klass->external_name(), deopt_segm_path) != NULL) { + if (TraceRedefineClasses > 0) { + tty->print_cr("Including in deoptimization : %s", this_klass->external_name()); + } + this_klass->set_deoptimization_incl(true); + deopt_found = true; + } + FREE_C_HEAP_ARRAY(char, deopt_segm_path, mtInternal); + deopt_path = tmp_end + 1; + } + } + if (TraceClassResolution) { ResourceMark rm; // print out the superclass. diff --git a/src/share/vm/classfile/systemDictionary.cpp b/src/share/vm/classfile/systemDictionary.cpp index e40b061..588e0e5 100644 --- a/src/share/vm/classfile/systemDictionary.cpp +++ b/src/share/vm/classfile/systemDictionary.cpp @@ -1255,6 +1255,31 @@ ik->restore_unshareable_info(loader_data, protection_domain, CHECK_(nh)); } + if (HotswapDeoptClassPath != NULL) { + const char* deopt_path = HotswapDeoptClassPath; + const char* const end = deopt_path + strlen(deopt_path); + bool deopt_found = false; + while (!deopt_found && deopt_path < end) { + const char* tmp_end = strchr(deopt_path, ','); + if (tmp_end == NULL) { + tmp_end = end; + } + char* deopt_segm_path = NEW_C_HEAP_ARRAY(char, tmp_end - deopt_path + 1, mtInternal); + memcpy(deopt_segm_path, deopt_path, tmp_end - deopt_path); + deopt_segm_path[tmp_end - deopt_path] = '\0'; + if (strstr(ik->external_name(), deopt_segm_path) != NULL) { + if (TraceRedefineClasses > 0) { + tty->print_cr("Including in deoptimization : %s", ik->external_name()); + } + ik->set_deoptimization_incl(true); + deopt_found = true; + } + FREE_C_HEAP_ARRAY(char, deopt_segm_path, mtInternal); + deopt_path = tmp_end + 1; + } + } + + if (TraceClassLoading) { ResourceMark rm; tty->print("[Loaded %s", ik->external_name()); diff --git a/src/share/vm/code/codeCache.cpp b/src/share/vm/code/codeCache.cpp index c9059d7..af10381 100644 --- a/src/share/vm/code/codeCache.cpp +++ b/src/share/vm/code/codeCache.cpp @@ -709,6 +709,13 @@ } #endif // HOTSWAP +// Deoptimize all methods having deopt-include flag +void CodeCache::mark_all_incl_nmethods_for_deoptimization() { + MutexLockerEx mu(CodeCache_lock, Mutex::_no_safepoint_check_flag); + FOR_ALL_ALIVE_NMETHODS(nm) { + nm->mark_for_deoptimization_incl(); + } +} // Deoptimize all methods void CodeCache::mark_all_nmethods_for_deoptimization() { diff --git a/src/share/vm/code/codeCache.hpp b/src/share/vm/code/codeCache.hpp index f098284..d4a1363 100644 --- a/src/share/vm/code/codeCache.hpp +++ b/src/share/vm/code/codeCache.hpp @@ -184,6 +184,7 @@ // tells how many nmethods have dependencies static int number_of_nmethods_with_dependencies(); + static void mark_all_incl_nmethods_for_deoptimization(); static int get_codemem_full_count() { return _codemem_full_count; } }; diff --git a/src/share/vm/code/nmethod.cpp b/src/share/vm/code/nmethod.cpp index 6ea39ae..bf2db7e 100644 --- a/src/share/vm/code/nmethod.cpp +++ b/src/share/vm/code/nmethod.cpp @@ -476,6 +476,7 @@ _lazy_critical_native = 0; _has_wide_vectors = 0; _marked_for_deoptimization = 0; + _deoptimization_incl = false; _lock_count = 0; _stack_traversal_mark = 0; _unload_reported = false; // jvmti state @@ -688,6 +689,7 @@ _dependencies_offset = _scopes_pcs_offset; _handler_table_offset = _dependencies_offset; _nul_chk_table_offset = _handler_table_offset; + _nmethod_end_offset = _nul_chk_table_offset; _compile_id = compile_id; _comp_level = CompLevel_none; @@ -697,6 +699,8 @@ _exception_cache = NULL; _pc_desc_cache.reset_to(NULL); _hotness_counter = NMethodSweeper::hotness_counter_reset_val(); + if (method != NULL) + _deoptimization_incl = method->method_holder()->is_deoptimization_incl(); code_buffer->copy_values_to(this); if (ScavengeRootsInCode) { @@ -772,6 +776,7 @@ _metadata_offset = _oops_offset + round_to(code_buffer->total_oop_size(), oopSize); _scopes_data_offset = _metadata_offset + round_to(code_buffer->total_metadata_size(), wordSize); _scopes_pcs_offset = _scopes_data_offset; + _dependencies_offset = _scopes_pcs_offset; _handler_table_offset = _dependencies_offset; _nul_chk_table_offset = _handler_table_offset; @@ -784,6 +789,8 @@ _exception_cache = NULL; _pc_desc_cache.reset_to(NULL); _hotness_counter = NMethodSweeper::hotness_counter_reset_val(); + if (method != NULL) + _deoptimization_incl = method->method_holder()->is_deoptimization_incl(); code_buffer->copy_values_to(this); if (ScavengeRootsInCode) { @@ -900,6 +907,9 @@ _exception_cache = NULL; _pc_desc_cache.reset_to(scopes_pcs_begin()); + if (method != NULL) + _deoptimization_incl = method->method_holder()->is_deoptimization_incl(); + // Copy contents of ScopeDescRecorder to nmethod code_buffer->copy_values_to(this); debug_info->copy_to(this); diff --git a/src/share/vm/code/nmethod.hpp b/src/share/vm/code/nmethod.hpp index b7d6890..3de4757 100644 --- a/src/share/vm/code/nmethod.hpp +++ b/src/share/vm/code/nmethod.hpp @@ -184,6 +184,8 @@ bool _marked_for_reclamation; // Used by NMethodSweeper (set only by sweeper) bool _marked_for_deoptimization; // Used for stack deoptimization + bool _deoptimization_incl; + // used by jvmti to track if an unload event has been posted for this nmethod. bool _unload_reported; @@ -470,6 +472,11 @@ bool is_marked_for_deoptimization() const { return _marked_for_deoptimization; } void mark_for_deoptimization() { _marked_for_deoptimization = true; } + bool is_deoptimization_incl() const { return _deoptimization_incl; } + void set_deoptimization_incl(bool z) { _deoptimization_incl = z; } + + void mark_for_deoptimization_incl() { if (_deoptimization_incl) _marked_for_deoptimization = true; } + void make_unloaded(BoolObjectClosure* is_alive, oop cause); bool has_dependencies() { return dependencies_size() != 0; } diff --git a/src/share/vm/oops/klass.cpp b/src/share/vm/oops/klass.cpp index 2e3d192..a889458 100644 --- a/src/share/vm/oops/klass.cpp +++ b/src/share/vm/oops/klass.cpp @@ -188,6 +188,7 @@ set_redefinition_flags(Klass::NoRedefinition); set_redefining(false); + set_deoptimization_incl(false); set_new_version(NULL); set_old_version(NULL); set_redefinition_index(-1); @@ -236,6 +237,8 @@ if (FastSuperclassLimit == 0) { // None of the other machinery matters. set_super(k); + if (k != NULL && k->is_deoptimization_incl()) + set_deoptimization_incl(true); return; } if (k == NULL) { @@ -247,6 +250,8 @@ "initialize this only once to a non-trivial value"); set_super(k); Klass* sup = k; + if (sup->is_deoptimization_incl()) + set_deoptimization_incl(true); int sup_depth = sup->super_depth(); juint my_depth = MIN2(sup_depth + 1, (int)primary_super_limit()); if (!can_be_primary_super_slow()) diff --git a/src/share/vm/oops/klass.hpp b/src/share/vm/oops/klass.hpp index e3fc3bd..c5fc46d 100644 --- a/src/share/vm/oops/klass.hpp +++ b/src/share/vm/oops/klass.hpp @@ -177,6 +177,7 @@ bool _original_field_offsets_changed; // Did the original field offsets of this class change during class redefinition? int * _update_information; // Update information bool _is_redefining; + bool _deoptimization_incl; // True if class methods are included in deoptimization // Biased locking implementation and statistics // (the 64-bit chunk goes first, to avoid some fragmentation) @@ -263,6 +264,9 @@ int *update_information() const { return _update_information; } void set_update_information(int *info) { _update_information = info; } + bool is_deoptimization_incl() const { return _deoptimization_incl; } + void set_deoptimization_incl(bool z) { _deoptimization_incl = z; } + // Revision number for redefined classes, -1 for originally loaded classes bool was_redefined() const { return _revision_number != -1; } jint revision_number() const { return _revision_number; } diff --git a/src/share/vm/prims/jvmtiRedefineClasses2.cpp b/src/share/vm/prims/jvmtiRedefineClasses2.cpp index f545b98..4fad1cb 100644 --- a/src/share/vm/prims/jvmtiRedefineClasses2.cpp +++ b/src/share/vm/prims/jvmtiRedefineClasses2.cpp @@ -443,6 +443,8 @@ new_class->set_redefinition_flags(redefinition_flags); + new_class->set_deoptimization_incl(true); + _max_redefinition_flags = _max_redefinition_flags | redefinition_flags; if ((redefinition_flags & Klass::ModifyInstances) != 0) { @@ -1572,7 +1574,10 @@ if (0 && JvmtiExport::all_dependencies_are_recorded()) { Universe::flush_evol_dependents_on(k_h); } else { - CodeCache::mark_all_nmethods_for_deoptimization(); + if (HotswapDeoptClassPath == NULL) + CodeCache::mark_all_nmethods_for_deoptimization(); + else + CodeCache::mark_all_incl_nmethods_for_deoptimization(); ResourceMark rm(THREAD); DeoptimizationMarker dm; diff --git a/src/share/vm/runtime/globals.hpp b/src/share/vm/runtime/globals.hpp index 9a51218..b8ca7bb 100644 --- a/src/share/vm/runtime/globals.hpp +++ b/src/share/vm/runtime/globals.hpp @@ -3962,7 +3962,16 @@ \ product_pd(bool, PreserveFramePointer, \ "Use the FP register for holding the frame pointer " \ - "and not as a general purpose register.") + "and not as a general purpose register.") \ + \ + product(ccstr, HotswapDeoptClassPath, NULL, \ + "Comma separated list of packages containing classes that are " \ + "expected to be redefined. If com.sun.proxy is used by " \ + "application and proxied class is redefined, then this option " \ + "should contain 'com.sun.proxy'. If the option is not defined, " \ + "then all classes will be deoptimized on hotswap. Using this " \ + "option improves hotswap performance. ") + /* * Macros for factoring of globals