diff options
| author | James Moger <james.moger@gitblit.com> | 2014-05-23 08:17:11 -0400 |
|---|---|---|
| committer | James Moger <james.moger@gitblit.com> | 2014-07-03 16:57:47 -0400 |
| commit | c828cf2db88956094a31a79741145688876879df (patch) | |
| tree | 7f9d7e8b0fe7d91350afb79b2baf60f543712150 /build.moxie | |
| parent | aa1361d04cfe09f90e7d8bece90c00dd6e4185bb (diff) | |
| download | gitblit-c828cf2db88956094a31a79741145688876879df.tar.gz gitblit-c828cf2db88956094a31a79741145688876879df.zip | |
Use Guice-Servlet rather than custom code and expose the Injector
This is a fairly functional variation of Gitblit with one notable
exception:
The security filters are not working properly.
This is a design flaw in Guice that I have reported upstream [1]. The
general idea is that Guice-Servlet filters are not properly wrapping the
ServletRequest. This has historically been a problem for Guice-Servlet
servlets but Google has fixed most of those issues. Unfortunately, all
the same flaws reported against the servlet delegation also exist in
Guice-Servlet filter delegation. :(
[1]: https://code.google.com/p/google-guice/issues/detail?id=807
Diffstat (limited to 'build.moxie')
| -rw-r--r-- | build.moxie | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/build.moxie b/build.moxie index 0501b779..b25a4222 100644 --- a/build.moxie +++ b/build.moxie @@ -112,6 +112,7 @@ properties: { wikitext.version : 1.4 sshd.version: 0.11.1-atlassian-1 mina.version: 2.0.7 + guice.version : 4.0-beta4 } # Dependencies @@ -127,7 +128,8 @@ properties: { dependencies: # Dagger dependency injection library (annotation processor) -- compile 'com.google.inject:guice:4.0-beta4' :war +- compile 'com.google.inject:guice:${guice.version}' :war +- compile 'com.google.inject.extensions:guice-servlet:${guice.version}' :war - compile 'com.google.guava:guava:16.0.1' :war # Standard dependencies - compile 'com.intellij:annotations:12.0' :war |