diff options
author | James Moger <james.moger@gitblit.com> | 2014-05-23 08:17:11 -0400 |
---|---|---|
committer | James Moger <james.moger@gitblit.com> | 2014-07-03 16:57:47 -0400 |
commit | c828cf2db88956094a31a79741145688876879df (patch) | |
tree | 7f9d7e8b0fe7d91350afb79b2baf60f543712150 /gitblit.iml | |
parent | aa1361d04cfe09f90e7d8bece90c00dd6e4185bb (diff) | |
download | gitblit-c828cf2db88956094a31a79741145688876879df.tar.gz gitblit-c828cf2db88956094a31a79741145688876879df.zip |
Use Guice-Servlet rather than custom code and expose the Injector
This is a fairly functional variation of Gitblit with one notable
exception:
The security filters are not working properly.
This is a design flaw in Guice that I have reported upstream [1]. The
general idea is that Guice-Servlet filters are not properly wrapping the
ServletRequest. This has historically been a problem for Guice-Servlet
servlets but Google has fixed most of those issues. Unfortunately, all
the same flaws reported against the servlet delegation also exist in
Guice-Servlet filter delegation. :(
[1]: https://code.google.com/p/google-guice/issues/detail?id=807
Diffstat (limited to 'gitblit.iml')
-rw-r--r-- | gitblit.iml | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/gitblit.iml b/gitblit.iml index 9a689dab..f8a8a674 100644 --- a/gitblit.iml +++ b/gitblit.iml @@ -58,6 +58,17 @@ </library> </orderEntry> <orderEntry type="module-library"> + <library name="guice-servlet-4.0-beta4.jar"> + <CLASSES> + <root url="jar://$MODULE_DIR$/ext/guice-servlet-4.0-beta4.jar!/" /> + </CLASSES> + <JAVADOC /> + <SOURCES> + <root url="jar://$MODULE_DIR$/ext/src/guice-servlet-4.0-beta4.jar!/" /> + </SOURCES> + </library> + </orderEntry> + <orderEntry type="module-library"> <library name="annotations-12.0.jar"> <CLASSES> <root url="jar://$MODULE_DIR$/ext/annotations-12.0.jar!/" /> |