Define manager interfaces and update all of Gitblit to use managers

These manager interfaces define how the GitBlit singleton will
eventually be split into smaller component managers.  The Wicket app and
all servlets have been updated to request the needed managers.  There
are _very_ few method signature changes - although there are a handful.

This is a surgical sharding of responsibility based on a proof of
concept refactor.  Instead of random references to  GittBlit.self()
there are now precise references to the manager interface required to
accomplish some task.  Some tasks may require references to multiple
managers.

The code is now littered with calls to GitBlit.getManager(class) and
those familiar with the code-base will no doubt notice the duplication
of methods from IUserService in IUserManager and the addition of
implementation methods in the GitBlit context class.  When the
GitBlit class is broken apart and the existing external authentication
user service classes are refactored to AuthenticationService classes,
this will again simplify and flatten.  But in order to safely and
cleanly modularize the stable code-base we will have to live with a
little duplication for a short while.

Change-Id: I7314ec8acaab2dcc6092785ed4434cc09fdbbe16

1 files changed, 15 insertions, 6 deletions

diff --git a/src/main/java/com/gitblit/utils/ActivityUtils.java b/src/main/java/com/gitblit/utils/ActivityUtils.java
index ddd7e371..3a54d33f 100644
--- a/src/main/java/com/gitblit/utils/ActivityUtils.java
+++ b/src/main/java/com/gitblit/utils/ActivityUtils.java
@@ -34,8 +34,9 @@ import java.util.TreeSet;
 import org.eclipse.jgit.lib.Constants;

 import org.eclipse.jgit.lib.Repository;

 

-import com.gitblit.GitBlit;

+import com.gitblit.IStoredSettings;

 import com.gitblit.Keys;

+import com.gitblit.manager.IRepositoryManager;

 import com.gitblit.models.Activity;

 import com.gitblit.models.GravatarProfile;

 import com.gitblit.models.RefModel;

@@ -55,6 +56,10 @@ public class ActivityUtils {
 	 * Gets the recent activity from the repositories for the last daysBack days

 	 * on the specified branch.

 	 *

+	 * @param settings

+	 *            the runtime settings

+	 * @param repositoryManager

+	 *            the repository manager

 	 * @param models

 	 *            the list of repositories to query

 	 * @param daysBack

@@ -66,8 +71,13 @@ public class ActivityUtils {
 	 *            the timezone for aggregating commits

 	 * @return

 	 */

-	public static List<Activity> getRecentActivity(List<RepositoryModel> models, int daysBack,

-			String objectId, TimeZone timezone) {

+	public static List<Activity> getRecentActivity(

+					IStoredSettings settings,

+					IRepositoryManager repositoryManager,

+					List<RepositoryModel> models,

+					int daysBack,

+					String objectId,

+					TimeZone timezone) {

 

 		// Activity panel shows last daysBack of activity across all

 		// repositories.

@@ -82,7 +92,7 @@ public class ActivityUtils {
 

 		// aggregate author exclusions

 		Set<String> authorExclusions = new TreeSet<String>();

-		authorExclusions.addAll(GitBlit.getStrings(Keys.web.metricAuthorExclusions));

+		authorExclusions.addAll(settings.getStrings(Keys.web.metricAuthorExclusions));

 		for (RepositoryModel model : models) {

 			if (!ArrayUtils.isEmpty(model.metricAuthorExclusions)) {

 				authorExclusions.addAll(model.metricAuthorExclusions);

@@ -99,8 +109,7 @@ public class ActivityUtils {
 				if (model.isCollectingGarbage) {

 					continue;

 				}

-				Repository repository = GitBlit.self()

-						.getRepository(model.name);

+				Repository repository = repositoryManager.getRepository(model.name);

 				List<String> branches = new ArrayList<String>();

 				if (StringUtils.isEmpty(objectId)) {

 					for (RefModel local : JGitUtils.getLocalBranches(