summaryrefslogtreecommitdiffstats
path: root/src/main/java/com/gitblit/git/GitblitReceivePack.java
Commit message (Collapse)AuthorAgeFilesLines
* Ticket Reference handling #1048Paul Martin2016-04-271-0/+243
| | | | | | | | | | | | | | | + Supports referencing: + Tickets from other tickets via comments + Tickets from commits on any branch + Common TicketLink class used for both commits and tickets + TicketLink is temporary and persisted to ticket as a Reference + Support deletion of ticket references + Rebasing patchsets/branches will generate new references + Deleting old patchsets/branches will remove the relevant references + Substantial testing of use cases + With and without patchsets, deleting, amending + BranchTicketService used during testing to allow end-to-end ref testing + Relocated common git helper functions to JGitUtils
* Tag server-side merges when incremental push tags are enabledJames Moger2014-05-231-59/+85
|
* Ensure the repository model ref list is refreshed on ref creation or deletionJames Moger2014-05-071-0/+8
|
* Expose JGit 3.x receive pack settings as Gitblit settingsJames Moger2014-04-171-0/+11
|
* Allow ReceiveHook extensionsJames Moger2014-04-121-6/+45
|
* Tweak the receive pack push permission check to be a methodJames Moger2014-03-121-1/+27
|
* Revise push/mirror tickets branch triggeringJames Moger2014-03-061-3/+3
|
* Fire an event on received ticket branch updates to trigger reindexJames Moger2014-03-051-0/+9
| | | | | | | | It would be useful to be able to push a complete repository with a refs/gitblit/tickets branch and have Gitblit index all those tickets. Additionally, it would be nice for the mirroring service to recognize an incoming update to this ref and fire an event that can be processed by the BranchTicketService, if so configured, to reindex the tickets.
* Ticket tracker with patchset contributionsJames Moger2014-03-031-0/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | A basic issue tracker styled as a hybrid of GitHub and BitBucket issues. You may attach commits to an existing ticket or you can push a single commit to create a *proposal* ticket. Tickets keep track of patchsets (one or more commits) and allow patchset rewriting (rebase, amend, squash) by detecing the non-fast-forward update and assigning a new patchset number to the new commits. Ticket tracker -------------- The ticket tracker stores tickets as an append-only journal of changes. The journals are deserialized and a ticket is built by applying the journal entries. Tickets are indexed using Apache Lucene and all queries and searches are executed against this Lucene index. There is one trade-off to this persistence design: user attributions are non-relational. What does that mean? Each journal entry stores the username of the author. If the username changes in the user service, the journal entry will not reflect that change because the values are hard-coded. Here are a few reasons/justifications for this design choice: 1. commit identifications (author, committer, tagger) are non-relational 2. maintains the KISS principle 3. your favorite text editor can still be your administration tool Persistence Choices ------------------- **FileTicketService**: stores journals on the filesystem **BranchTicketService**: stores journals on an orphan branch **RedisTicketService**: stores journals in a Redis key-value datastore It should be relatively straight-forward to develop other backends (MongoDB, etc) as long as the journal design is preserved. Pushing Commits --------------- Each push to a ticket is identified as a patchset revision. A patchset revision may add commits to the patchset (fast-forward) OR a patchset revision may rewrite history (rebase, squash, rebase+squash, or amend). Patchset authors should not be afraid to polish, revise, and rewrite their code before merging into the proposed branch. Gitblit will create one ref for each patchset. These refs are updated for fast-forward pushes or created for rewrites. They are formatted as `refs/tickets/{shard}/{id}/{patchset}`. The *shard* is the last two digits of the id. If the id < 10, prefix a 0. The *shard* is always two digits long. The shard's purpose is to ensure Gitblit doesn't exceed any filesystem directory limits for file creation. **Creating a Proposal Ticket** You may create a new change proposal ticket just by pushing a **single commit** to `refs/for/{branch}` where branch is the proposed integration branch OR `refs/for/new` or `refs/for/default` which both will use the default repository branch. git push origin HEAD:refs/for/new **Updating a Patchset** The safe way to update an existing patchset is to push to the patchset ref. git push origin HEAD:refs/heads/ticket/{id} This ensures you do not accidentally create a new patchset in the event that the patchset was updated after you last pulled. The not-so-safe way to update an existing patchset is to push using the magic ref. git push origin HEAD:refs/for/{id} This push ref will update an exisitng patchset OR create a new patchset if the update is non-fast-forward. **Rebasing, Squashing, Amending** Gitblit makes rebasing, squashing, and amending patchsets easy. Normally, pushing a non-fast-forward update would require rewind (RW+) repository permissions. Gitblit provides a magic ref which will allow ticket participants to rewrite a ticket patchset as long as the ticket is open. git push origin HEAD:refs/for/{id} Pushing changes to this ref allows the patchset authors to rebase, squash, or amend the patchset commits without requiring client-side use of the *--force* flag on push AND without requiring RW+ permission to the repository. Since each patchset is tracked with a ref it is easy to recover from accidental non-fast-forward updates. Features -------- - Ticket tracker with status changes and responsible assignments - Patchset revision scoring mechanism - Update/Rewrite patchset handling - Close-on-push detection - Server-side Merge button for simple merges - Comments with Markdown syntax support - Rich mail notifications - Voting - Mentions - Watch lists - Querying - Searches - Partial miletones support - Multiple backend options
* Do not log empty messages in the receive packJames Moger2014-02-281-2/+6
|
* Tweak info logging in GitblitReceivePack and open variable scopeJames Moger2013-12-301-7/+7
| | | | Change-Id: I11624daca0694dc1996795b31432274467f09228
* New canonical base url setting for repository urls and notificationsJames Moger2013-12-301-6/+0
| | | | Change-Id: I86a1eb61c2351d1cf3f6b3becf00f2a36d5c8ed6
* Flattened IGitblitManager, GitblitManager, and GitBlit classesJames Moger2013-11-291-3/+3
| | | | Change-Id: Id6deb27306e0034898673bf5d5d76a4ed012ced6
* Revised committer verification to require email addressJames Moger2013-11-291-12/+8
| | | | Change-Id: I5298c93e03099813f5713a4effd87913429aa3dc
* Update unit tests for refactored architectureJames Moger2013-11-291-1/+1
| | | | Change-Id: I04639db977c515e5e1090ef8f0e1ce858820cb03
* Renamed Gitblit to GitBlit to not break existing Groovy hooksJames Moger2013-11-291-3/+3
| | | | Change-Id: Id5286ed1b9d7e92644cacf857096e6dd273c8f05
* Create a Gitblit aggregate manager delegate for git upload/receive tasksJames Moger2013-11-291-13/+10
| | | | Change-Id: I2c4a5ddf051f228c0bd949c6cd4fd44c3da81d26
* Use Dagger to inject managers into all filters and servletsJames Moger2013-11-291-8/+12
| | | | Change-Id: I9bb2cc0cbfac9841b13bed15a474fefb24355cd4
* Define manager interfaces and update all of Gitblit to use managersJames Moger2013-11-261-5/+16
| | | | | | | | | | | | | | | | | | | | | | | | | These manager interfaces define how the GitBlit singleton will eventually be split into smaller component managers. The Wicket app and all servlets have been updated to request the needed managers. There are _very_ few method signature changes - although there are a handful. This is a surgical sharding of responsibility based on a proof of concept refactor. Instead of random references to GittBlit.self() there are now precise references to the manager interface required to accomplish some task. Some tasks may require references to multiple managers. The code is now littered with calls to GitBlit.getManager(class) and those familiar with the code-base will no doubt notice the duplication of methods from IUserService in IUserManager and the addition of implementation methods in the GitBlit context class. When the GitBlit class is broken apart and the existing external authentication user service classes are refactored to AuthenticationService classes, this will again simplify and flatten. But in order to safely and cleanly modularize the stable code-base we will have to live with a little duplication for a short while. Change-Id: I7314ec8acaab2dcc6092785ed4434cc09fdbbe16
* Implement mirror executor (issue-5)James Moger2013-11-131-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | | The mirror executor will fetch ref updates for repository mirrors. This feature is disabled by default and can be enabled by setting git.enableMirroring=true. The period between update checks is configurable, but it is global. An individual rpeository may not set it's own update schedule. Requirements: 1. you must manually clone the repository using native git git clone --mirror git://somewhere.com/myrepo.git 2. the "origin" remote must be the mirror source 3. the "origin" repository must be accessible without authentication OR the credentials must be embedded in the origin url (not recommended) Notes: 1. "origin" SSH urls are untested and not likely to work 2. mirrors cloned while Gitblit is running are likely to require clearing the gitblit cache (link on the repositories page of an administrator account) 3. Gitblit will automatically repair any invalid fetch refspecs with a "//" sequence. Change-Id: I4bbe3fb2df106366ae4c2313596d0fab0dfcac46
* Improve message logging in the receive packJames Moger2013-10-011-3/+11
| | | | Change-Id: I93dcdc72bfae0e0fac9a0f4872537a43bbd73d36
* Trim trailing whitespace and organize importsJames Moger2013-09-301-1/+1
| | | | Change-Id: I9f91138b20219be6e3c4b28251487df262bff6cc
* Merge receive processing into one classJames Moger2013-09-271-0/+467
Change-Id: I603d4524914e94ec8e02c3689b65465b42c23dd7